summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Elder <paul.elder@ideasonboard.com>2021-01-21 17:30:59 +0900
committerPaul Elder <paul.elder@ideasonboard.com>2021-01-27 12:06:55 +0900
commite5b6774422b66b4caee544b12c3aea14e3416ded (patch)
treedd4754440c54746ed4b6f92c0904359be2cc9e9a
parentd81e26d360e649c37a1b859331c3348c7b9089ec (diff)
android: jpeg: exif: Fix setOrientation EXIF values
The input to setOrientation is angle clockwise from the sensor orientation, while the EXIF output values were swapped for 90 and 270 degrees. From the EXIF spec: 6 = The 0th row is the visual right-hand side of the image, and the 0th column is the visual top. 8 = The 0th row is the visual left-hand side of the image, and the 0th column is the visual bottom. 6 should be 90 degrees clockwise, while 8 should 270 degrees clockwise. Fix this. As Android defines the rotation as the clockwise angle by which the image needs to be rotated to appear in the correct orientation on the device screen, the previous values would be correct if the input angle was from the camera orientation. Since the correct input should be the requested JPEG orientation, these new values are the correct ones. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
-rw-r--r--src/android/jpeg/exif.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp
index 89343323..204a237a 100644
--- a/src/android/jpeg/exif.cpp
+++ b/src/android/jpeg/exif.cpp
@@ -306,13 +306,13 @@ void Exif::setOrientation(int orientation)
value = 1;
break;
case 90:
- value = 8;
+ value = 6;
break;
case 180:
value = 3;
break;
case 270:
- value = 6;
+ value = 8;
break;
}