summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUmang Jain <email@uajain.com>2020-10-23 11:01:50 +0530
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-10-23 22:53:17 +0300
commitc430d39d203488cf93ab4f12ff9eb8b3c6380212 (patch)
treeaba274f0b7af500ed40e201160987354df3e55c6
parentf9e7f55f3b2cdee93a51cf7f39a2e72b4c453e00 (diff)
android: jpeg: encoder: Use pass-by-value for Exif parameter
Following the reasoning of pass-by-value for libcamera::Span parameters from 90c193f2a700("android: Modify Encoder interface") i.e. they are easy to copy/move/construct, align the Exif parameter passing to the encoder interface in this consistent way. Signed-off-by: Umang Jain <email@uajain.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-rw-r--r--src/android/jpeg/encoder.h2
-rw-r--r--src/android/jpeg/encoder_libjpeg.cpp2
-rw-r--r--src/android/jpeg/encoder_libjpeg.h2
3 files changed, 3 insertions, 3 deletions
diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h
index 0ca2ba38..027233dc 100644
--- a/src/android/jpeg/encoder.h
+++ b/src/android/jpeg/encoder.h
@@ -19,7 +19,7 @@ public:
virtual int configure(const libcamera::StreamConfiguration &cfg) = 0;
virtual int encode(const libcamera::FrameBuffer &source,
libcamera::Span<uint8_t> destination,
- const libcamera::Span<const uint8_t> &exifData) = 0;
+ libcamera::Span<const uint8_t> exifData) = 0;
};
#endif /* __ANDROID_JPEG_ENCODER_H__ */
diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp
index 4bea10cf..cfa53321 100644
--- a/src/android/jpeg/encoder_libjpeg.cpp
+++ b/src/android/jpeg/encoder_libjpeg.cpp
@@ -180,7 +180,7 @@ void EncoderLibJpeg::compressNV(const MappedBuffer *frame)
}
int EncoderLibJpeg::encode(const FrameBuffer &source, Span<uint8_t> dest,
- const Span<const uint8_t> &exifData)
+ Span<const uint8_t> exifData)
{
MappedFrameBuffer frame(&source, PROT_READ);
if (!frame.isValid()) {
diff --git a/src/android/jpeg/encoder_libjpeg.h b/src/android/jpeg/encoder_libjpeg.h
index 391a53ca..40505ddc 100644
--- a/src/android/jpeg/encoder_libjpeg.h
+++ b/src/android/jpeg/encoder_libjpeg.h
@@ -23,7 +23,7 @@ public:
int configure(const libcamera::StreamConfiguration &cfg) override;
int encode(const libcamera::FrameBuffer &source,
libcamera::Span<uint8_t> destination,
- const libcamera::Span<const uint8_t> &exifData) override;
+ libcamera::Span<const uint8_t> exifData) override;
private:
void compressRGB(const libcamera::MappedBuffer *frame);