From ace50f75a4d4c10c0deb90fc857525b565cdd8c9 Mon Sep 17 00:00:00 2001
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Sat, 28 Sep 2019 16:22:24 +0300
Subject: libcamera: controls: Rename ControlInfo to ControlRange
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The ControlInfo class stores a range of valid values for a control. Its
name is vague, as "info" has multiple meanings. Rename it to
ControlRange.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 test/controls/control_info.cpp  | 51 -----------------------------------------
 test/controls/control_range.cpp | 51 +++++++++++++++++++++++++++++++++++++++++
 test/controls/meson.build       |  2 +-
 3 files changed, 52 insertions(+), 52 deletions(-)
 delete mode 100644 test/controls/control_info.cpp
 create mode 100644 test/controls/control_range.cpp

(limited to 'test')

diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp
deleted file mode 100644
index 9cf59185..00000000
--- a/test/controls/control_info.cpp
+++ /dev/null
@@ -1,51 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-/*
- * Copyright (C) 2019, Google Inc.
- *
- * control_info.cpp - ControlInfo tests
- */
-
-#include <iostream>
-
-#include <libcamera/control_ids.h>
-#include <libcamera/controls.h>
-
-#include "test.h"
-
-using namespace std;
-using namespace libcamera;
-
-class ControlInfoTest : public Test
-{
-protected:
-	int run()
-	{
-		/*
-		 * Test information retrieval from a control with no minimum
-		 * and maximum.
-		 */
-		ControlInfo brightness;
-
-		if (brightness.min().get<int32_t>() != 0 ||
-		    brightness.max().get<int32_t>() != 0) {
-			cout << "Invalid control range for Brightness" << endl;
-			return TestFail;
-		}
-
-		/*
-		 * Test information retrieval from a control with a minimum and
-		 * a maximum value.
-		 */
-		ControlInfo contrast(10, 200);
-
-		if (contrast.min().get<int32_t>() != 10 ||
-		    contrast.max().get<int32_t>() != 200) {
-			cout << "Invalid control range for Contrast" << endl;
-			return TestFail;
-		}
-
-		return TestPass;
-	}
-};
-
-TEST_REGISTER(ControlInfoTest)
diff --git a/test/controls/control_range.cpp b/test/controls/control_range.cpp
new file mode 100644
index 00000000..06ec3506
--- /dev/null
+++ b/test/controls/control_range.cpp
@@ -0,0 +1,51 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Copyright (C) 2019, Google Inc.
+ *
+ * control_range.cpp - ControlRange tests
+ */
+
+#include <iostream>
+
+#include <libcamera/control_ids.h>
+#include <libcamera/controls.h>
+
+#include "test.h"
+
+using namespace std;
+using namespace libcamera;
+
+class ControlRangeTest : public Test
+{
+protected:
+	int run()
+	{
+		/*
+		 * Test information retrieval from a range with no minimum and
+		 * maximum.
+		 */
+		ControlRange brightness;
+
+		if (brightness.min().get<int32_t>() != 0 ||
+		    brightness.max().get<int32_t>() != 0) {
+			cout << "Invalid control range for Brightness" << endl;
+			return TestFail;
+		}
+
+		/*
+		 * Test information retrieval from a control with a minimum and
+		 * a maximum value.
+		 */
+		ControlRange contrast(10, 200);
+
+		if (contrast.min().get<int32_t>() != 10 ||
+		    contrast.max().get<int32_t>() != 200) {
+			cout << "Invalid control range for Contrast" << endl;
+			return TestFail;
+		}
+
+		return TestPass;
+	}
+};
+
+TEST_REGISTER(ControlRangeTest)
diff --git a/test/controls/meson.build b/test/controls/meson.build
index f4fc7b94..9f0f005a 100644
--- a/test/controls/meson.build
+++ b/test/controls/meson.build
@@ -1,6 +1,6 @@
 control_tests = [
-    [ 'control_info',   'control_info.cpp' ],
     [ 'control_list',   'control_list.cpp' ],
+    [ 'control_range',  'control_range.cpp' ],
     [ 'control_value',  'control_value.cpp' ],
 ]
 
-- 
cgit v1.2.1