From 5bb6607933f28d2484b68034f871cd58074ae695 Mon Sep 17 00:00:00 2001 From: Umang Jain <email@uajain.com> Date: Fri, 15 May 2020 12:42:52 +0000 Subject: test: log: log_process: Close open fds on error paths Reported-by: Coverity CID=279097 Signed-off-by: Umang Jain <email@uajain.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- test/log/log_process.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp index 8463d0ed..d46d5e35 100644 --- a/test/log/log_process.cpp +++ b/test/log/log_process.cpp @@ -107,6 +107,7 @@ protected: memset(buf, 0, sizeof(buf)); if (read(fd, buf, sizeof(buf)) < 0) { cerr << "Failed to read tmp log file" << endl; + close(fd); return TestFail; } close(fd); -- cgit v1.2.1