From 18647a532483470d9f64bc6cb1bbeeda39c2670d Mon Sep 17 00:00:00 2001 From: Kieran Bingham Date: Tue, 19 Mar 2019 11:32:09 +0000 Subject: libcamera: media_device: Initialise local variable The local variable ifaceId generates a compiler warning that it is used without initialisation. The loop, and check against the loop iterator, and the topology.num_interfaces actually ensures that this isn't the case, and that ifaceId can only be used when set to a valid ID. The media_v2_interface.id field documents the ID as simply "Unique ID for the interface" but does not specify if zero is a valid ID or not. As such we don't further check the pre-initialised ID for validity and keep the existing check on the iterator count to determine if the ID had been discovered successfully. Fixes: d4af90d72901 ("libcamera: media_device: Create entities with major and minor numbers") Acked-by: Jacopo Mondi Signed-off-by: Kieran Bingham --- src/libcamera/media_device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp index ea460893..1e9024bf 100644 --- a/src/libcamera/media_device.cpp +++ b/src/libcamera/media_device.cpp @@ -516,7 +516,7 @@ struct media_v2_interface *MediaDevice::findInterface(const struct media_v2_topo { struct media_v2_link *links = reinterpret_cast (topology.ptr_links); - unsigned int ifaceId; + unsigned int ifaceId = 0; unsigned int i; for (i = 0; i < topology.num_links; ++i) { -- cgit v1.2.1