libcamera/vivid.git - libcamera pipeline handler for VIVID

Age	Commit message (Collapse)	Author
2022-03-25	libcamera: base: timer: Drop start() overload with int argument	Laurent Pinchart
	The start(unsigned int msec) overload is error-prone, as the argument unit can easily be mistaken in callers. Drop it and update all callers to use the start(std::chrono::milliseconds) overload instead. The callers now need to use std::chrono_literals. The using statement could be added to timer.h for convenience, but "using" is discouraged in header files to avoid namespace pollution. Update the callers instead, and while at it, sort the "using" statements alphabetically in tests. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
2021-06-25	libcamera/base: Move File to base library	Kieran Bingham
	The File abstraction is a base helper and not part of the libcamera API. Move it to to allow usage by users of the base library. Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
2021-06-25	libcamera/base: Move extended base functionality	Kieran Bingham
	Move the functionality for the following components to the new base support library: - BoundMethod - EventDispatcher - EventDispatcherPoll - Log - Message - Object - Signal - Semaphore - Thread - Timer While it would be preferable to see these split to move one component per commit, these components are all interdependent upon each other, which leaves us with one big change performing the move for all of them. Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
2020-11-15	libcamera: Move EventDispatcher to internal API	Laurent Pinchart
	There's no user of the EventDispatcher (and the related EventNotifier and Timer classes) outside of libcamera. Move those classes to the internal API. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
2020-08-25	meson: Remove -Wno-unused-parameter	Laurent Pinchart
	We build libcamera with -Wno-unused-parameter and this doesn't cause much issue internally. However, it prevents catching unused parameters in inline functions defined in public headers. This can lead to compilation warnings for applications compiled without -Wno-unused-parameter. To catch those issues, remove -Wno-unused-parameter and fix all the related warnings with [[maybe_unused]]. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
2020-06-17	tests: Introduce hotplug hot-unplug unit test	Umang Jain
	This test checks the code-paths for camera's hotplugged and unplugged support. It is based on bind/unbind of a UVC device from sysfs. Hence, this test requires root permissions to run and should have at least one already bound UVC device present in the system. Signed-off-by: Umang Jain <email@uajain.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

/* SPDX-License-Identifier: GPL-2.0-or-later */ /* * Copyright (C) 2020, Google Inc. * * flags.cpp - Flags tests */ #include <iostream> #include <libcamera/base/flags.h> #include "test.h" using namespace libcamera; using namespace std; class FlagsTest : public Test { protected: enum class Option { First = (1 << 0), Second = (1 << 1), Third = (1 << 2), }; using Options = Flags<Option>; enum class Mode { Alpha = (1 << 0), Beta = (1 << 1), Gamma = (1 << 2), }; using Modes = Flags<Mode>; int run() override; }; namespace libcamera { LIBCAMERA_FLAGS_ENABLE_OPERATORS(FlagsTest::Option) } /* namespace libcamera */ int FlagsTest::run() { /* Commented-out constructs are expected not to compile. */ /* Flags<int> f; */ /* * Unary operators with enum argument. */ Options options; if (options) { cerr << "Default-constructed Flags<> is not zero" << endl; return TestFail; } options |= Option::First; if (!options || options != Option::First) { cerr << "Unary bitwise OR with enum failed" << endl; return TestFail; } /* options &= Mode::Alpha; */ /* options |= Mode::Beta; */ /* options ^= Mode::Gamma; */ options &= ~Option::First; if (options) { cerr << "Unary bitwise AND with enum failed" << endl; return TestFail; } options ^= Option::Second; if (options != Option::Second) { cerr << "Unary bitwise XOR with enum failed" << endl; return TestFail; } options = Options(); /* * Unary operators with Flags argument. */ options |= Options(Option::First); if (options != Option::First) { cerr << "Unary bitwise OR with Flags<> failed" << endl; return TestFail; } /* options &= Options(Mode::Alpha); */ /* options |= Options(Mode::Beta); */ /* options ^= Options(Mode::Gamma); */ options &= ~Options(Option::First); if (options) { cerr << "Unary bitwise AND with Flags<> failed" << endl; return TestFail; } options ^= Options(Option::Second); if (options != Option::Second) { cerr << "Unary bitwise XOR with Flags<> failed" << endl; return TestFail; } options = Options(); /* * Binary operators with enum argument. */ options = options | Option::First; if (!(options & Option::First)) { cerr << "Binary bitwise OR with enum failed" << endl; return TestFail; } /* options = options & Mode::Alpha; */ /* options = options | Mode::Beta; */ /* options = options ^ Mode::Gamma; */ options = options & ~Option::First; if (options != (Option::First & Option::Second)) { cerr << "Binary bitwise AND with enum failed" << endl; return TestFail; } options = options ^ (Option::First ^ Option::Second); if (options != (Option::First | Option::Second)) { cerr << "Binary bitwise XOR with enum failed" << endl; return TestFail; } options = Options(); /* * Binary operators with Flags argument. */ options |= Options(Option::First); if (!(options & Option::First)) { cerr << "Binary bitwise OR with Flags<> failed" << endl; return TestFail; } /* options = options & Options(Mode::Alpha); */ /* options = options | Options(Mode::Beta); */ /* options = options ^ Options(Mode::Gamma); */ options = options & ~Options(Option::First); if (options) { cerr << "Binary bitwise AND with Flags<> failed" << endl; return TestFail; } options = options ^ Options(Option::Second); if (options != Option::Second) { cerr << "Binary bitwise XOR with Flags<> failed" << endl; return TestFail; } options = Options(); /* * Conversion operators. */ options |= Option::First | Option::Second | Option::Third; if (static_cast<Options::Type>(options) != 7) { cerr << "Cast to underlying type failed" << endl; return TestFail; } /* * Conversion of the result of ninary operators on the underlying enum. */ /* unsigned int val1 = Option::First; */ /* unsigned int val2 = ~Option::First; */ /* unsigned int val3 = Option::First | Option::Second; */ /* Option val4 = ~Option::First; */ /* Option val5 = Option::First | Option::Second; */ return TestPass; } TEST_REGISTER(FlagsTest)