summaryrefslogtreecommitdiff
path: root/src/qcam
diff options
context:
space:
mode:
authorNiklas Söderlund <niklas.soderlund@ragnatech.se>2020-03-17 04:29:06 +0100
committerNiklas Söderlund <niklas.soderlund@ragnatech.se>2020-03-18 18:02:40 +0100
commitaaf1ce50f9602c838428c8a089e28b83666b759b (patch)
tree2281db443dced74fb3a2431814431fa576f81eda /src/qcam
parent718f5e99a966246de8d129902ad470872652b749 (diff)
libcamera: PixelFormat: Mark all function arguments of type PixelFormat as const reference
PixelFormat was previously an alias for unsigned int but is now a class. Make all functions taking PixelFormat do so as a const reference. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'src/qcam')
-rw-r--r--src/qcam/format_converter.cpp4
-rw-r--r--src/qcam/format_converter.h2
-rw-r--r--src/qcam/viewfinder.cpp4
-rw-r--r--src/qcam/viewfinder.h2
4 files changed, 6 insertions, 6 deletions
diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp
index 7b8ad77c..483f7c1e 100644
--- a/src/qcam/format_converter.cpp
+++ b/src/qcam/format_converter.cpp
@@ -25,8 +25,8 @@
#define CLIP(x) CLAMP(x,0,255)
#endif
-int FormatConverter::configure(libcamera::PixelFormat format, unsigned int width,
- unsigned int height)
+int FormatConverter::configure(const libcamera::PixelFormat &format,
+ unsigned int width, unsigned int height)
{
switch (format) {
case DRM_FORMAT_NV12:
diff --git a/src/qcam/format_converter.h b/src/qcam/format_converter.h
index ff488b99..96bde238 100644
--- a/src/qcam/format_converter.h
+++ b/src/qcam/format_converter.h
@@ -16,7 +16,7 @@ class QImage;
class FormatConverter
{
public:
- int configure(libcamera::PixelFormat format, unsigned int width,
+ int configure(const libcamera::PixelFormat &format, unsigned int width,
unsigned int height);
void convert(const unsigned char *src, size_t size, QImage *dst);
diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp
index 0ebb8edd..e9d5cc1e 100644
--- a/src/qcam/viewfinder.cpp
+++ b/src/qcam/viewfinder.cpp
@@ -44,8 +44,8 @@ QImage ViewFinder::getCurrentImage()
return image_->copy();
}
-int ViewFinder::setFormat(libcamera::PixelFormat format, unsigned int width,
- unsigned int height)
+int ViewFinder::setFormat(const libcamera::PixelFormat &format,
+ unsigned int width, unsigned int height)
{
int ret;
diff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h
index 2668aa44..0549f038 100644
--- a/src/qcam/viewfinder.h
+++ b/src/qcam/viewfinder.h
@@ -22,7 +22,7 @@ public:
ViewFinder(QWidget *parent);
~ViewFinder();
- int setFormat(libcamera::PixelFormat format, unsigned int width,
+ int setFormat(const libcamera::PixelFormat &format, unsigned int width,
unsigned int height);
void display(const unsigned char *rgb, size_t size);