libcamera/vivid.git - libcamera pipeline handler for VIVID

diff options

author	Laurent Pinchart <laurent.pinchart@ideasonboard.com>	2022-07-11 01:09:09 +0300
committer	Laurent Pinchart <laurent.pinchart@ideasonboard.com>	2022-07-19 14:23:32 +0300
commit	f995ff25a3326db90513d1fa936815653f7cade0 (patch)
tree	d4362bac38bb83efbe7aa5d936e1d2b858854437 /src/qcam/assets/feathericons/map-pin.svg
parent	1c4d4801850559d6f919eef5c2ffbaf7675dbc46 (diff)

libcamera: controls: Avoid double lookups

Now that the ControlList::get() function returns an instance of std::optional<>, we can replace the ControlList::contains() calls with a nullopt check on the return value of get(). This avoids double lookups of controls through the code base. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

Diffstat (limited to 'src/qcam/assets/feathericons/map-pin.svg')

0 files changed, 0 insertions, 0 deletions

/* SPDX-License-Identifier: LGPL-2.1-or-later */ /* * Copyright (C) 2019, Google Inc. * * V4L2 compatibility manager */ #include "v4l2_compat_manager.h" #include <dlfcn.h> #include <fcntl.h> #include <map> #include <string.h> #include <sys/eventfd.h> #include <sys/mman.h> #include <sys/stat.h> #include <sys/sysmacros.h> #include <sys/types.h> #include <unistd.h> #include <libcamera/base/log.h> #include <libcamera/base/utils.h> #include <libcamera/camera.h> #include <libcamera/camera_manager.h> #include <libcamera/property_ids.h> #include "v4l2_camera_file.h" using namespace libcamera; LOG_DEFINE_CATEGORY(V4L2Compat) namespace { template<typename T> void get_symbol(T &func, const char *name) { func = reinterpret_cast<T>(dlsym(RTLD_NEXT, name)); } } /* namespace */ V4L2CompatManager::V4L2CompatManager() : cm_(nullptr) { get_symbol(fops_.openat, "openat64"); get_symbol(fops_.dup, "dup"); get_symbol(fops_.close, "close"); get_symbol(fops_.ioctl, "ioctl"); get_symbol(fops_.mmap, "mmap64"); get_symbol(fops_.munmap, "munmap"); } V4L2CompatManager::~V4L2CompatManager() { files_.clear(); mmaps_.clear(); if (cm_) { proxies_.clear(); cm_->stop(); delete cm_; cm_ = nullptr; } } int V4L2CompatManager::start() { cm_ = new CameraManager(); int ret = cm_->start(); if (ret) { LOG(V4L2Compat, Error) << "Failed to start camera manager: " << strerror(-ret); delete cm_; cm_ = nullptr; return ret; } LOG(V4L2Compat, Debug) << "Started camera manager"; /* * For each Camera registered in the system, a V4L2CameraProxy gets * created here to wrap a camera device. */ auto cameras = cm_->cameras(); for (auto [index, camera] : utils::enumerate(cameras)) { V4L2CameraProxy *proxy = new V4L2CameraProxy(index, camera); proxies_.emplace_back(proxy); } return 0; } V4L2CompatManager *V4L2CompatManager::instance() { static V4L2CompatManager instance; return &instance; } std::shared_ptr<V4L2CameraFile> V4L2CompatManager::cameraFile(int fd) { auto file = files_.find(fd); if (file == files_.end()) return nullptr; return file->second; } int V4L2CompatManager::getCameraIndex(int fd) { struct stat statbuf; int ret = fstat(fd, &statbuf); if (ret < 0) return -1; const dev_t devnum = statbuf.st_rdev; /* * Iterate each known camera and identify if it reports this nodes * device number in its list of SystemDevices. */ auto cameras = cm_->cameras(); for (auto [index, camera] : utils::enumerate(cameras)) { Span<const int64_t> devices = camera->properties() .get(properties::SystemDevices) .value_or(Span<int64_t>{}); /* * While there may be multiple cameras that could reference the * same device node, we take a first match as a best effort for


context:
space:
mode: