libcamera/vivid.git - libcamera pipeline handler for VIVID

diff options

author	Jacopo Mondi <jacopo@jmondi.org>	2021-07-28 11:59:00 +0200
committer	Jacopo Mondi <jacopo@jmondi.org>	2021-08-12 10:06:25 +0200
commit	b48db3c489d3af5989cc9a71b0843fc69adbcc1f (patch)
tree	ba18fa50459de3f09b184973adaafe17b21df49c /src/ipa/raspberrypi/data/imx378.json
parent	0e1ff86e78ae1813b29972ce4a682ad99dbb41e3 (diff)

libcamera: controls: Create ControlInfoMap with ControlIdMap

ControlInfoMap does not have a ControlId map associated, but rather creates one with the generateIdMap() function at creation time. As a consequence, when in the need to de-serialize a ControlInfoMap all the ControlId it contains are created by the deserializer instance, not being able to discern if the controls the ControlIdMap refers to are the global libcamera controls (and properties) or instances local to the V4L2 device that has first initialized the controls. As a consequence the ControlId stored in a de-serialized map will always be newly created entities, preventing lookup by ControlId reference on a de-serialized ControlInfoMap. In order to make it possible to use globally available ControlId instances whenever possible, create ControlInfoMap with a reference to an externally allocated ControlIdMap instead of generating one internally. As a consequence the class constructors take and additional argument, which might be not pleasant to type in, but enforces the concepts that ControlInfoMap should be created with controls part of the same id map. As the ControlIdMap the ControlInfoMap refers to needs to be allocated externally: - Use the globally available controls::controls (or properties::properties) id map when referring to libcamera controls - The V4L2 device that creates ControlInfoMap by parsing the device's controls has to allocate a ControlIdMap - The ControlSerializer that de-serializes a ControlInfoMap has to create and store the ControlIdMap the de-serialized info map refers to Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Diffstat (limited to 'src/ipa/raspberrypi/data/imx378.json')

0 files changed, 0 insertions, 0 deletions

/* SPDX-License-Identifier: GPL-2.0-or-later */ /* * Copyright (C) 2020, Google Inc. * * span.cpp - Span tests */ /* * Include first to ensure the header is self-contained, as there's no span.cpp * in libcamera. */ #include <libcamera/base/span.h> #include <array> #include <iostream> #include <vector> #include "test.h" using namespace std; using namespace libcamera; class SpanTest : public Test { protected: int run() { int i[4]{ 1, 2, 3, 4 }; std::array<int, 4> a{ 1, 2, 3, 4 }; const std::array<int, 4> ca{ 1, 2, 3, 4 }; std::vector<int> v{ 1, 2, 3, 4 }; const std::vector<int> cv{ 1, 2, 3, 4 }; /* * Compile-test construction and usage of spans with static * extent. Commented-out tests are expected not to compile, or * to generate undefined behaviour. */ Span<int, 0>{}; /* Span<int, 4>{}; */ Span<int, 4>{ &i[0], 4 }; Span<int, 4>{ &i[0], &i[3] }; Span<int, 4>{ i }; /* Span<float, 4>{ i }; */ /* Span<int, 2>{ i }; */ Span<int, 4>{ a }; Span<const int, 4>{ a }; /* Span<float, 4>{ a }; */ /* Span<int, 2>{ a }; */ Span<const int, 4>{ ca }; /* Span<const int, 2>{ ca }; */ /* Span<const float, 4>{ ca }; */ /* Span<int, 4>{ ca }; */ Span<int, 4>{ v }; Span<const int, 4>{ v }; /* Span<float, 4>{ v }; */ Span<const int, 4>{ v }; /* Span<int, 4>{ v }; */ /* Span<const float, 4>{ v }; */ Span<int, 4> staticSpan{ i }; Span<int, 4>{ staticSpan }; Span<const int, 4>{ staticSpan }; /* Span<const int, 2>{ staticSpan }; */ staticSpan = Span<int, 4>{ v }; if (*staticSpan.begin() != 1) { std::cout << "Span<static_extent>::begin() failed" << std::endl; return TestFail; } if (*staticSpan.cbegin() != 1) { std::cout << "Span<static_extent>::cbegin() failed" << std::endl; return TestFail; } staticSpan.end(); staticSpan.cend(); if (*staticSpan.rbegin() != 4) { std::cout << "Span<static_extent>::rbegin() failed" << std::endl; return TestFail; } if (*staticSpan.crbegin() != 4) { std::cout << "Span<static_extent>::crbegin() failed" << std::endl; return TestFail; } staticSpan.rend(); staticSpan.crend(); staticSpan.front(); staticSpan.back(); staticSpan[0]; staticSpan.data(); staticSpan.size(); staticSpan.size_bytes(); staticSpan.empty(); staticSpan.first<2>(); staticSpan.first(2); /* staticSpan.first<6>(); */ /* staticSpan.first(6); */ staticSpan.last<2>(); staticSpan.last(2); /* staticSpan.last<6>(); */ /* staticSpan.last(6); */ staticSpan.subspan<1>(); staticSpan.subspan<1, 2>(); staticSpan.subspan(1); staticSpan.subspan(1, 2); /* staticSpan.subspan(2, 4); */ /* * Compile-test construction and usage of spans with dynamic * extent. Commented-out tests are expected not to compile, or * to generate undefined behaviour. */ Span<int>{}; Span<int>{ &i[0], 4 }; Span<int>{ &i[0], &i[3] }; Span<int>{ i }; /* Span<float>{ i }; */ Span<int>{ a }; Span<const int>{ a }; /* Span<float>{ a }; */ Span<const int>{ ca }; /* Span<const float>{ca}; */ /* Span<int>{ca}; */ Span<int>{ v }; Span<const int>{ v }; /* Span<float>{ v }; */ Span<const int>{ v }; /* Span<int>{ v }; */ /* Span<const float>{ v }; */ Span<int> dynamicSpan{ i }; Span<int>{ dynamicSpan }; Span<const int>{ dynamicSpan }; dynamicSpan = Span<int>{ a }; if (*dynamicSpan.begin() != 1) { std::cout << "Span<dynamic_extent>::begin() failed" << std::endl; return TestFail; } if (*dynamicSpan.cbegin() != 1) { std::cout << "Span<dynamic_extent>::cbegin() failed" << std::endl; return TestFail; } dynamicSpan.end(); dynamicSpan.cend(); if (*dynamicSpan.rbegin() != 4) { std::cout << "Span<dynamic_extent>::rbegin() failed" << std::endl; return TestFail; } if (*dynamicSpan.crbegin() != 4) { std::cout << "Span<dynamic_extent>::crbegin() failed" << std::endl; return TestFail; } dynamicSpan.rend(); dynamicSpan.crend(); dynamicSpan.front(); dynamicSpan.back(); dynamicSpan[0]; dynamicSpan.data(); dynamicSpan.size(); dynamicSpan.size_bytes(); dynamicSpan.empty(); dynamicSpan.first<2>(); dynamicSpan.first(2); /* dynamicSpan.first<6>(); */ /* dynamicSpan.first(6); */ dynamicSpan.last<2>(); dynamicSpan.last(2); /* dynamicSpan.last<6>(); */ /* dynamicSpan.last(6); */ dynamicSpan.subspan<1>(); dynamicSpan.subspan<1, 2>(); dynamicSpan.subspan(1); dynamicSpan.subspan(1, 2); /* dynamicSpan.subspan(2, 4); */ return TestPass; } }; TEST_REGISTER(SpanTest)


context:
space:
mode: