summaryrefslogtreecommitdiff
path: root/src/ipa/raspberrypi/controller/rpi/noise.cpp
diff options
context:
space:
mode:
authorNaushir Patuck <naush@raspberrypi.com>2023-05-03 13:20:27 +0100
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2023-05-04 20:47:40 +0300
commit726e9274ea95fa46352556d340c5793a8da51fcd (patch)
tree80f6adcdbf744f9317e09eff3e80c602b384a753 /src/ipa/raspberrypi/controller/rpi/noise.cpp
parent46aefed208fef4bc8d6f6e8882b92b9af710a60b (diff)
pipeline: ipa: raspberrypi: Refactor and move the Raspberry Pi code
Split the Raspberry Pi pipeline handler and IPA source code into common and VC4/BCM2835 specific file structures. For the pipeline handler, the common code files now live in src/libcamera/pipeline/rpi/common/ and the VC4-specific files in src/libcamera/pipeline/rpi/vc4/. For the IPA, the common code files now live in src/ipa/rpi/{cam_helper,controller}/ and the vc4 specific files in src/ipa/rpi/vc4/. With this change, the camera tuning files are now installed under share/libcamera/ipa/rpi/vc4/. To build the pipeline and IPA, the meson configuration options have now changed from "raspberrypi" to "rpi/vc4": meson setup build -Dipas=rpi/vc4 -Dpipelines=rpi/vc4 Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'src/ipa/raspberrypi/controller/rpi/noise.cpp')
-rw-r--r--src/ipa/raspberrypi/controller/rpi/noise.cpp89
1 files changed, 0 insertions, 89 deletions
diff --git a/src/ipa/raspberrypi/controller/rpi/noise.cpp b/src/ipa/raspberrypi/controller/rpi/noise.cpp
deleted file mode 100644
index bcd8b9ed..00000000
--- a/src/ipa/raspberrypi/controller/rpi/noise.cpp
+++ /dev/null
@@ -1,89 +0,0 @@
-/* SPDX-License-Identifier: BSD-2-Clause */
-/*
- * Copyright (C) 2019, Raspberry Pi Ltd
- *
- * noise.cpp - Noise control algorithm
- */
-
-#include <math.h>
-
-#include <libcamera/base/log.h>
-
-#include "../device_status.h"
-#include "../noise_status.h"
-
-#include "noise.h"
-
-using namespace RPiController;
-using namespace libcamera;
-
-LOG_DEFINE_CATEGORY(RPiNoise)
-
-#define NAME "rpi.noise"
-
-Noise::Noise(Controller *controller)
- : Algorithm(controller), modeFactor_(1.0)
-{
-}
-
-char const *Noise::name() const
-{
- return NAME;
-}
-
-void Noise::switchMode(CameraMode const &cameraMode,
- [[maybe_unused]] Metadata *metadata)
-{
- /*
- * For example, we would expect a 2x2 binned mode to have a "noise
- * factor" of sqrt(2x2) = 2. (can't be less than one, right?)
- */
- modeFactor_ = std::max(1.0, cameraMode.noiseFactor);
-}
-
-int Noise::read(const libcamera::YamlObject &params)
-{
- auto value = params["reference_constant"].get<double>();
- if (!value)
- return -EINVAL;
- referenceConstant_ = *value;
-
- value = params["reference_slope"].get<double>();
- if (!value)
- return -EINVAL;
- referenceSlope_ = *value;
-
- return 0;
-}
-
-void Noise::prepare(Metadata *imageMetadata)
-{
- struct DeviceStatus deviceStatus;
- deviceStatus.analogueGain = 1.0; /* keep compiler calm */
- if (imageMetadata->get("device.status", deviceStatus) == 0) {
- /*
- * There is a slight question as to exactly how the noise
- * profile, specifically the constant part of it, scales. For
- * now we assume it all scales the same, and we'll revisit this
- * if it proves substantially wrong. NOTE: we may also want to
- * make some adjustments based on the camera mode (such as
- * binning), if we knew how to discover it...
- */
- double factor = sqrt(deviceStatus.analogueGain) / modeFactor_;
- struct NoiseStatus status;
- status.noiseConstant = referenceConstant_ * factor;
- status.noiseSlope = referenceSlope_ * factor;
- imageMetadata->set("noise.status", status);
- LOG(RPiNoise, Debug)
- << "constant " << status.noiseConstant
- << " slope " << status.noiseSlope;
- } else
- LOG(RPiNoise, Warning) << " no metadata";
-}
-
-/* Register algorithm with the system. */
-static Algorithm *create(Controller *controller)
-{
- return new Noise(controller);
-}
-static RegisterAlgorithm reg(NAME, &create);