summaryrefslogtreecommitdiff
path: root/src/ipa/raspberrypi/cam_helper_ov5647.cpp
diff options
context:
space:
mode:
authorNaushir Patuck <naush@raspberrypi.com>2021-01-29 11:16:14 +0000
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2021-02-05 01:23:20 +0200
commit362301b1313085f198b463f3ce4df794df50ad0d (patch)
tree4b12b51df3c93a611f31fcf44007d933daaa5535 /src/ipa/raspberrypi/cam_helper_ov5647.cpp
parentd7fd40ea2b17ea67a6ac495ba831abe1977ed283 (diff)
ipa: raspberrypi: Limit the calculated vblank based on the sensor mode
The existing framerate/vblank calculations did not account for the sensor mode limits. This commit extracts vblank limits from the sensor v4l2 controls, and stores it in the camera modes structure. Exposure and vblank value calculations now use values clamped to the sensor mode limits. The libcamera::controls::FrameDurations metadata return values now reflect the minimum and maximum after clamping. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'src/ipa/raspberrypi/cam_helper_ov5647.cpp')
-rw-r--r--src/ipa/raspberrypi/cam_helper_ov5647.cpp4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/ipa/raspberrypi/cam_helper_ov5647.cpp b/src/ipa/raspberrypi/cam_helper_ov5647.cpp
index 2bd8a754..a7f41732 100644
--- a/src/ipa/raspberrypi/cam_helper_ov5647.cpp
+++ b/src/ipa/raspberrypi/cam_helper_ov5647.cpp
@@ -30,8 +30,6 @@ private:
* in units of lines.
*/
static constexpr int frameIntegrationDiff = 4;
- /* Largest possible frame length, in units of lines. */
- static constexpr int maxFrameLength = 0xffff;
};
/*
@@ -40,7 +38,7 @@ private:
*/
CamHelperOv5647::CamHelperOv5647()
- : CamHelper(new MdParserRPi(), maxFrameLength, frameIntegrationDiff)
+ : CamHelper(new MdParserRPi(), frameIntegrationDiff)
{
}