libcamera/vivid.git - libcamera pipeline handler for VIVID

diff options

author	Naushir Patuck <naush@raspberrypi.com>	2023-10-13 08:48:30 +0100
committer	Kieran Bingham <kieran.bingham@ideasonboard.com>	2023-10-18 11:01:22 +0100
commit	0be32012ef378ad22b2715a2bddee0acfce33f92 (patch)
tree	83a7d5789b751f44659630a7cdeb84a0d03820e7 /package/gentoo/media-libs
parent	56ca5091debff3a74a9ff146ee6a15eda47047bc (diff)

ipa: rpi: Prepare ALSC for PiSP support

Prepare the ALSC algorithm to support the PiSP hardware. The key change is to avoid factoring out the WB correction in the AWB zone statistics. Add the ALSC correction to the global metadata so that AWB can use it to factor the gains back in for the AWB calculations. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Diffstat (limited to 'package/gentoo/media-libs')

0 files changed, 0 insertions, 0 deletions

#!/usr/bin/python3 # SPDX-License-Identifier: GPL-2.0-or-later # Copyright (C) 2018, Google Inc. # # Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # # checkstyle.py - A patch style checker script based on clang-format # # TODO: # # - Support other formatting tools and checkers (cppcheck, cpplint, kwstyle, ...) # - Split large hunks to minimize context noise # - Improve style issues counting # import argparse import difflib import fnmatch import os.path import re import shutil import subprocess import sys dependencies = { 'clang-format': True, 'git': True, } # ------------------------------------------------------------------------------ # Colour terminal handling # class Colours: Default = 0 Black = 0 Red = 31 Green = 32 Yellow = 33 Blue = 34 Magenta = 35 Cyan = 36 LightGrey = 37 DarkGrey = 90 LightRed = 91 LightGreen = 92 Lightyellow = 93 LightBlue = 94 LightMagenta = 95 LightCyan = 96 White = 97 @staticmethod def fg(colour): if sys.stdout.isatty(): return '\033[%um' % colour else: return '' @staticmethod def bg(colour): if sys.stdout.isatty(): return '\033[%um' % (colour + 10) else: return '' @staticmethod def reset(): if sys.stdout.isatty(): return '\033[0m' else: return '' # ------------------------------------------------------------------------------ # Diff parsing, handling and printing # class DiffHunkSide(object): """A side of a diff hunk, recording line numbers""" def __init__(self, start): self.start = start self.touched = [] self.untouched = [] def __len__(self): return len(self.touched) + len(self.untouched) class DiffHunk(object): diff_header_regex = re.compile(r'@@ -([0-9]+),?([0-9]+)? \+([0-9]+),?([0-9]+)? @@') def __init__(self, line): match = DiffHunk.diff_header_regex.match(line) if not match: raise RuntimeError("Malformed diff hunk header '%s'" % line) self.__from_line = int(match.group(1)) self.__to_line = int(match.group(3)) self.__from = DiffHunkSide(self.__from_line) self.__to = DiffHunkSide(self.__to_line) self.lines = [] def __repr__(self): s = '%s@@ -%u,%u +%u,%u @@\n' % \ (Colours.fg(Colours.Cyan), self.__from.start, len(self.__from), self.__to.start, len(self.__to)) for line in self.lines: if line[0] == '-': s += Colours.fg(Colours.Red) elif line[0] == '+': s += Colours.fg(Colours.Green) if line[0] == '-': spaces = 0 for i in range(len(line)): if line[-i-1].isspace(): spaces += 1 else: break spaces = len(line) - spaces line = line[0:spaces] + Colours.bg(Colours.Red) + line[spaces:] s += line s += Colours.reset() s += '\n' return s[:-1] def append(self, line): if line[0] == ' ': self.__from.untouched.append(self.__from_line) self.__from_line += 1 self.__to.untouched.append(self.__to_line) self.__to_line += 1 elif line[0] == '-': self.__from.touched.append(self.__from_line) self.__from_line += 1 elif line[0] == '+': self.__to.touched.append(self.__to_line) self.__to_line += 1 self.lines.append(line.rstrip('\n')) def intersects(self, lines): for line in lines: if line in self.__from.touched: return True return False def side(self, side): if side == 'from': return self.__from else: return self.__to def parse_diff(diff): hunks = [] hunk = None for line in diff: if line.startswith('@@'): if hunk: hunks.append(hunk) hunk = DiffHunk(line) elif hunk is not None: hunk.append(line) if hunk: hunks.append(hunk) return hunks # ------------------------------------------------------------------------------ # Commit, Staged Changes & Amendments # class CommitFile: def __init__(self, name): info = name.split() self.__status = info[0][0] # For renamed files, store the new name if self.__status == 'R': self.__filename = info[2] else: self.__filename = info[1] def __repr__(self): return f'{self.__status} {self.__filename}' @property def filename(self): return self.__filename @property def status(self): return self.__status class Commit: def __init__(self, commit): self.commit = commit self._trailers = [] self._parse() def _parse_trailers(self, lines): for index in range(1, len(lines)): line = lines[index] if not line: break self._trailers.append(line) return index def _parse(self): # Get the commit title and list of files. ret = subprocess.run(['git', 'show', '--format=%s%n%(trailers:only,unfold)', '--name-status', self.commit], stdout=subprocess.PIPE).stdout.decode('utf-8') lines = ret.splitlines() self._title = lines[0] index = self._parse_trailers(lines) self._files = [CommitFile(f) for f in lines[index:] if f] def files(self, filter='AMR'): return [f.filename for f in self._files if f.status in filter] @property def title(self): return self._title @property def trailers(self): return self._trailers def get_diff(self, top_level, filename): diff = subprocess.run(['git', 'diff', '%s~..%s' % (self.commit, self.commit), '--', '%s/%s' % (top_level, filename)], stdout=subprocess.PIPE).stdout.decode('utf-8') return parse_diff(diff.splitlines(True)) def get_file(self, filename): return subprocess.run(['git', 'show', '%s:%s' % (self.commit, filename)], stdout=subprocess.PIPE).stdout.decode('utf-8') class StagedChanges(Commit): def __init__(self): Commit.__init__(self, '') def _parse(self): ret = subprocess.run(['git', 'diff', '--staged', '--name-status'], stdout=subprocess.PIPE).stdout.decode('utf-8') self._title = 'Staged changes' self._files = [CommitFile(f) for f in ret.splitlines()] def get_diff(self, top_level, filename): diff = subprocess.run(['git', 'diff', '--staged', '--', '%s/%s' % (top_level, filename)], stdout=subprocess.PIPE).stdout.decode('utf-8') return parse_diff(diff.splitlines(True)) class Amendment(Commit): def __init__(self): Commit.__init__(self, '') def _parse(self): # Create a title using HEAD commit and parse the trailers. ret = subprocess.run(['git', 'show', '--format=%H %s%n%(trailers:only,unfold)', '--no-patch'], stdout=subprocess.PIPE).stdout.decode('utf-8') lines = ret.splitlines() self._title = 'Amendment of ' + lines[0].strip() self._parse_trailers(lines) # Extract the list of modified files ret = subprocess.run(['git', 'diff', '--staged', '--name-status', 'HEAD~'], stdout=subprocess.PIPE).stdout.decode('utf-8') self._files = [CommitFile(f) for f in ret.splitlines()] def get_diff(self, top_level, filename): diff = subprocess.run(['git', 'diff', '--staged', 'HEAD~', '--', '%s/%s' % (top_level, filename)], stdout=subprocess.PIPE).stdout.decode('utf-8') return parse_diff(diff.splitlines(True)) # ------------------------------------------------------------------------------ # Helpers # class ClassRegistry(type): def __new__(cls, clsname, bases, attrs): newclass = super().__new__(cls, clsname, bases, attrs) if bases: bases[0].subclasses.append(newclass) bases[0].subclasses.sort(key=lambda x: getattr(x, 'priority', 0), reverse=True) return newclass # ------------------------------------------------------------------------------ # Commit Checkers # class CommitChecker(metaclass=ClassRegistry): subclasses = [] def __init__(self): pass # # Class methods # @classmethod def checkers(cls, names): for checker in cls.subclasses: if names and checker.__name__ not in names: continue yield checker class CommitIssue(object): def __init__(self, msg): self.msg = msg class HeaderAddChecker(CommitChecker): @classmethod def check(cls, commit, top_level): issues = [] meson_files = [f for f in commit.files() if os.path.basename(f) == 'meson.build'] for filename in commit.files('AR'): if not filename.startswith('include/libcamera/') or \ not filename.endswith('.h'): continue meson = os.path.dirname(filename) + '/meson.build' header = os.path.basename(filename) issue = CommitIssue('Header %s added without corresponding update to %s' % (filename, meson)) if meson not in meson_files: issues.append(issue) continue diff = commit.get_diff(top_level, meson) found = False for hunk in diff: for line in hunk.lines: if line[0] != '+': continue if line.find("'%s'" % header) != -1: found = True break if found: break if not found: issues.append(issue) return issues class TitleChecker(CommitChecker): prefix_regex = re.compile(r'^([a-zA-Z0-9_.-]+: )+') release_regex = re.compile(r'libcamera v[0-9]+\.[0-9]+\.[0-9]+') @classmethod def check(cls, commit, top_level): title = commit.title # Skip the check when validating staged changes (as done through a # pre-commit hook) as there is no title to check in that case. if isinstance(commit, StagedChanges): return [] # Ignore release commits, they don't need a prefix. if TitleChecker.release_regex.fullmatch(title): return [] prefix_pos = title.find(': ') if prefix_pos != -1 and prefix_pos != len(title) - 2: return [] # Find prefix candidates by searching the git history msgs = subprocess.run(['git', 'log', '--no-decorate', '--oneline', '-n100', '--'] + commit.files(), stdout=subprocess.PIPE).stdout.decode('utf-8') prefixes = {} prefixes_count = 0 for msg in msgs.splitlines(): prefix = TitleChecker.prefix_regex.match(msg) if not prefix: continue prefix = prefix.group(0) if prefix in prefixes: prefixes[prefix] += 1 else: prefixes[prefix] = 1 prefixes_count += 1 if not prefixes: return [CommitIssue('Commit title is missing prefix')] # Sort the candidates by number of occurrences and pick the best ones. # When multiple prefixes are possible without a clear winner, we want to # display the most common options to the user, but without the most # unlikely options to avoid too long messages. As a heuristic, select # enough candidates to cover at least 2/3 of the possible prefixes, but # never more than 4 candidates. prefixes = list(prefixes.items()) prefixes.sort(key=lambda x: x[1], reverse=True) candidates = [] candidates_count = 0 for prefix in prefixes: candidates.append(f"`{prefix[0]}'") candidates_count += prefix[1] if candidates_count >= prefixes_count * 2 / 3 or \ len(candidates) == 4: break candidates = candidates[:-2] + [' or '.join(candidates[-2:])] candidates = ', '.join(candidates) return [CommitIssue('Commit title is missing prefix, ' 'possible candidates are ' + candidates)] class TrailersChecker(CommitChecker): commit_regex = re.compile(r'[0-9a-f]{12}[0-9a-f]* \(".*"\)') coverity_regex = re.compile(r'Coverity CID=.*') # Simple e-mail address validator regex, with an additional trailing # comment. The complexity of a full RFC6531 validator isn't worth the # additional invalid addresses it would reject. email_regex = re.compile(r'[^<]+ <[^@>]+@[^>]+>( # .*)?') link_regex = re.compile(r'https?://.*') @staticmethod def validate_reported_by(value): if TrailersChecker.email_regex.fullmatch(value): return True if TrailersChecker.coverity_regex.fullmatch(value): return True return False known_trailers = { 'Acked-by': email_regex, 'Bug': link_regex, 'Fixes': commit_regex, 'Link': link_regex, 'Reported-by': validate_reported_by, 'Reviewed-by': email_regex, 'Signed-off-by': email_regex, 'Suggested-by': email_regex, 'Tested-by': email_regex, } trailer_regex = re.compile(r'([A-Z][a-zA-Z-]*)\s*:\s*(.*)') @classmethod def check(cls, commit, top_level): issues = [] for trailer in commit.trailers: match = TrailersChecker.trailer_regex.fullmatch(trailer) if not match: issues.append(CommitIssue(f"Malformed commit trailer '{trailer}'")) continue key, value = match.groups() validator = TrailersChecker.known_trailers.get(key) if not validator: issues.append(CommitIssue(f"Invalid commit trailer key '{key}'")) continue if isinstance(validator, re.Pattern): valid = bool(validator.fullmatch(value)) else: valid = validator(value) if not valid: issues.append(CommitIssue(f"Malformed value '{value}' for commit trailer '{key}'")) continue return issues


context:
space:
mode: