summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-10-23 07:51:56 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-10-23 22:53:13 +0300
commitc77d894a8b2b441baafd7b2d689a1c668e56c382 (patch)
tree5004637683442d148f5bf220f9a209b3221cf518 /include
parent0c1f7da15ed91bf53034631180de744756afbacf (diff)
libcamera: Declare empty virtual destructors as defaulted
The base class of polymorphic classes is required to declare a destructor. Several of these are empty, and can thus be declared as defaulted. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <email@uajain.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'include')
-rw-r--r--include/libcamera/bound_method.h4
-rw-r--r--include/libcamera/internal/control_validator.h2
-rw-r--r--include/libcamera/internal/ipa_proxy.h2
-rw-r--r--include/libcamera/internal/media_object.h2
-rw-r--r--include/libcamera/internal/pipeline_handler.h4
-rw-r--r--include/libcamera/ipa/ipa_interface.h2
6 files changed, 8 insertions, 8 deletions
diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h
index d1e44483..95a95653 100644
--- a/include/libcamera/bound_method.h
+++ b/include/libcamera/bound_method.h
@@ -26,7 +26,7 @@ enum ConnectionType {
class BoundMethodPackBase
{
public:
- virtual ~BoundMethodPackBase() {}
+ virtual ~BoundMethodPackBase() = default;
};
template<typename R, typename... Args>
@@ -61,7 +61,7 @@ public:
: obj_(obj), object_(object), connectionType_(type)
{
}
- virtual ~BoundMethodBase() {}
+ virtual ~BoundMethodBase() = default;
template<typename T, typename std::enable_if_t<!std::is_same<Object, T>::value> * = nullptr>
bool match(T *obj) { return obj == obj_; }
diff --git a/include/libcamera/internal/control_validator.h b/include/libcamera/internal/control_validator.h
index 4a00b9b7..20600695 100644
--- a/include/libcamera/internal/control_validator.h
+++ b/include/libcamera/internal/control_validator.h
@@ -16,7 +16,7 @@ class ControlId;
class ControlValidator
{
public:
- virtual ~ControlValidator() {}
+ virtual ~ControlValidator() = default;
virtual const std::string &name() const = 0;
virtual bool validate(unsigned int id) const = 0;
diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h
index b429ce5a..49399f4e 100644
--- a/include/libcamera/internal/ipa_proxy.h
+++ b/include/libcamera/internal/ipa_proxy.h
@@ -42,7 +42,7 @@ class IPAProxyFactory
{
public:
IPAProxyFactory(const char *name);
- virtual ~IPAProxyFactory() {}
+ virtual ~IPAProxyFactory() = default;
virtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0;
diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h
index 54311c14..43a35bef 100644
--- a/include/libcamera/internal/media_object.h
+++ b/include/libcamera/internal/media_object.h
@@ -31,7 +31,7 @@ protected:
: dev_(dev), id_(id)
{
}
- virtual ~MediaObject() {}
+ virtual ~MediaObject() = default;
MediaDevice *dev_;
unsigned int id_;
diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h
index a4e1b529..c12c8904 100644
--- a/include/libcamera/internal/pipeline_handler.h
+++ b/include/libcamera/internal/pipeline_handler.h
@@ -40,7 +40,7 @@ public:
: pipe_(pipe)
{
}
- virtual ~CameraData() {}
+ virtual ~CameraData() = default;
Camera *camera_;
PipelineHandler *pipe_;
@@ -118,7 +118,7 @@ class PipelineHandlerFactory
{
public:
PipelineHandlerFactory(const char *name);
- virtual ~PipelineHandlerFactory() {}
+ virtual ~PipelineHandlerFactory() = default;
std::shared_ptr<PipelineHandler> create(CameraManager *manager);
diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
index 5016ec25..322b7079 100644
--- a/include/libcamera/ipa/ipa_interface.h
+++ b/include/libcamera/ipa/ipa_interface.h
@@ -150,7 +150,7 @@ struct CameraSensorInfo;
class IPAInterface
{
public:
- virtual ~IPAInterface() {}
+ virtual ~IPAInterface() = default;
virtual int init(const IPASettings &settings) = 0;
virtual int start() = 0;