summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacopo Mondi <jacopo@jmondi.org>2020-06-30 17:24:53 +0200
committerJacopo Mondi <jacopo@jmondi.org>2020-08-03 11:16:17 +0200
commited9fcf29e7d836fa1bd0b44931bfbe6369654a83 (patch)
tree808ff4fdd723276e4617f0dd213acc991546ba8d
parente0f8ce8454764ed27d5b1c2fcf22383f67def36b (diff)
libcamera: ipu3: Remove streams from IPU3CameraConfiguration
The IPU3CameraConfiguration::streams_ field was used to keep an association between the StreamConfiguration and the assigned streams before CameraConfiguration::setStream() was called at configure() time. The stream assignment was based on the order in which elements were inserted in the vector, implementing a fragile association between streams and their intended configurations. As it is now possible to assign streams at validation time, there is no need to keep that association in place, and the streams_ vector is now unused. Remove it and the associated accessor method from the IPU3CameraConfiguration class. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
-rw-r--r--src/libcamera/pipeline/ipu3/ipu3.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index 0701fa55..e90d0910 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -67,7 +67,6 @@ public:
Status validate() override;
const StreamConfiguration &cio2Format() const { return cio2Configuration_; };
- const std::vector<const Stream *> &streams() { return streams_; }
private:
/*
@@ -79,7 +78,6 @@ private:
const IPU3CameraData *data_;
StreamConfiguration cio2Configuration_;
- std::vector<const Stream *> streams_;
};
class PipelineHandlerIPU3 : public PipelineHandler