summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2021-07-12 01:49:46 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2021-07-19 08:20:13 +0300
commit8847715ccdeb44d09dd8a49399257da235ffcc23 (patch)
tree823cfd174988588758b59e08a45f458326e88b9d
parente8a28b4b9bd8791373957fce3f5c3f49f0cc04cf (diff)
libcamera: ipa_manager: Fix IPA module min/max version check
The IPAManager::createIPA() function has its minVersion and maxVersion parameters inverted. This doesn't cause any issue at the moment as both the minimum and maximum version are set to 1 by all callers, but it's still a bug. Fix it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
-rw-r--r--include/libcamera/internal/ipa_manager.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h
index 34224e33..42201839 100644
--- a/include/libcamera/internal/ipa_manager.h
+++ b/include/libcamera/internal/ipa_manager.h
@@ -31,8 +31,8 @@ public:
template<typename T>
static std::unique_ptr<T> createIPA(PipelineHandler *pipe,
- uint32_t maxVersion,
- uint32_t minVersion)
+ uint32_t minVersion,
+ uint32_t maxVersion)
{
IPAModule *m = nullptr;