summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-06-04 03:39:30 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-06-05 22:07:56 +0300
commitf1cac536f40fca701aa3ba4fe19d2f326c8bcc8e (patch)
tree114e3a0bd5a22472adc6a2842fd4c085c29cbaa8
parentb60a7d708a345346a30e89893af200a65c20859a (diff)
libcamera: Mark logPrefix() implementations with override
Virtual functions overriden in derived classes should be marked with the override keyword. Do so for the logPrefix() implementations inheriting from the Loggable class. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
-rw-r--r--include/libcamera/internal/camera_sensor.h2
-rw-r--r--include/libcamera/internal/media_device.h2
-rw-r--r--include/libcamera/internal/v4l2_subdevice.h2
-rw-r--r--include/libcamera/internal/v4l2_videodevice.h2
4 files changed, 4 insertions, 4 deletions
diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h
index d79bd9ce..eb464114 100644
--- a/include/libcamera/internal/camera_sensor.h
+++ b/include/libcamera/internal/camera_sensor.h
@@ -66,7 +66,7 @@ public:
int sensorInfo(CameraSensorInfo *info) const;
protected:
- std::string logPrefix() const;
+ std::string logPrefix() const override;
private:
const MediaEntity *entity_;
diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h
index 19af059d..20e397cc 100644
--- a/include/libcamera/internal/media_device.h
+++ b/include/libcamera/internal/media_device.h
@@ -55,7 +55,7 @@ public:
Signal<MediaDevice *> disconnected;
protected:
- std::string logPrefix() const;
+ std::string logPrefix() const override;
private:
int open();
diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h
index 1be454f0..07dc93d9 100644
--- a/include/libcamera/internal/v4l2_subdevice.h
+++ b/include/libcamera/internal/v4l2_subdevice.h
@@ -62,7 +62,7 @@ public:
const std::string &entity);
protected:
- std::string logPrefix() const;
+ std::string logPrefix() const override;
private:
std::vector<unsigned int> enumPadCodes(unsigned int pad);
diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h
index dc259523..cbaee614 100644
--- a/include/libcamera/internal/v4l2_videodevice.h
+++ b/include/libcamera/internal/v4l2_videodevice.h
@@ -213,7 +213,7 @@ public:
V4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat);
protected:
- std::string logPrefix() const;
+ std::string logPrefix() const override;
private:
int getFormatMeta(V4L2DeviceFormat *format);