diff options
| author | Jacopo Mondi <jacopo@jmondi.org> | 2021-07-16 15:51:59 +0200 |
|---|---|---|
| committer | Jacopo Mondi <jacopo@jmondi.org> | 2021-08-12 10:08:32 +0200 |
| commit | 9947b4cf381756c7174ba0179c774d4501a277f7 (patch) | |
| tree | 278da68b3f63764cbc93bd7fe9284ce4aa09f3fe | |
| parent | 11fe4333c54d6ffd69b6911520ab5aa47893b58d (diff) | |
ipa: ipu3: Tidy-up includes
Tidy-up a bit the inclusions directive in the IPU3 IPA module.
In detail:
- ipu3.cpp is missing inclusions for:
std::abs from <cmath>
std::map from <map>
std::min/max from <algorithm>
std::numeric_limits from <limits>
std::unique_ptr from <memory>
std::vector from <vector>
and does not require <sys/mman.h>
- ipu3_agc has two not used inclusions in the header file and one the cpp file
and is missing <chrono> for std::literals::chrono_literals
- ipu3_awb is missing <algorithm> for std::sort and does not use
<numeric> or <unordered_map>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
| -rw-r--r-- | src/ipa/ipu3/ipu3.cpp | 6 | ||||
| -rw-r--r-- | src/ipa/ipu3/ipu3_agc.cpp | 2 | ||||
| -rw-r--r-- | src/ipa/ipu3/ipu3_agc.h | 3 | ||||
| -rw-r--r-- | src/ipa/ipu3/ipu3_awb.cpp | 3 |
4 files changed, 8 insertions, 6 deletions
diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index 36a06966..c34fa460 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -5,9 +5,15 @@ * ipu3.cpp - IPU3 Image Processing Algorithms */ +#include <algorithm> #include <array> +#include <cmath> +#include <limits> +#include <map> +#include <memory> #include <stdint.h> #include <utility> +#include <vector> #include <linux/intel-ipu3.h> #include <linux/v4l2-controls.h> diff --git a/src/ipa/ipu3/ipu3_agc.cpp b/src/ipa/ipu3/ipu3_agc.cpp index 6253ab94..408eb849 100644 --- a/src/ipa/ipu3/ipu3_agc.cpp +++ b/src/ipa/ipu3/ipu3_agc.cpp @@ -8,8 +8,8 @@ #include "ipu3_agc.h" #include <algorithm> +#include <chrono> #include <cmath> -#include <numeric> #include <libcamera/base/log.h> diff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h index 3deca3ae..9f3d4257 100644 --- a/src/ipa/ipu3/ipu3_agc.h +++ b/src/ipa/ipu3/ipu3_agc.h @@ -7,9 +7,6 @@ #ifndef __LIBCAMERA_IPU3_AGC_H__ #define __LIBCAMERA_IPU3_AGC_H__ -#include <array> -#include <unordered_map> - #include <linux/intel-ipu3.h> #include <libcamera/base/utils.h> diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp index 9b409c8f..4bb321b3 100644 --- a/src/ipa/ipu3/ipu3_awb.cpp +++ b/src/ipa/ipu3/ipu3_awb.cpp @@ -6,9 +6,8 @@ */ #include "ipu3_awb.h" +#include <algorithm> #include <cmath> -#include <numeric> -#include <unordered_map> #include <libcamera/base/log.h> |