summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>2022-07-01 11:45:06 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2022-08-18 22:00:43 +0300
commita7f73dd096e02320b44b8819e44189ffbaf406a5 (patch)
treef02054b276460752b4615659087cb24835bc582c
parent93629989a9a8710f1cea3f4df934ec1c696fa412 (diff)
py: Add Python logging category
Add Python logging category, and use it in handleRequestCompleted(). Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-rw-r--r--src/py/libcamera/py_main.cpp12
-rw-r--r--src/py/libcamera/py_main.h14
2 files changed, 24 insertions, 2 deletions
diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp
index 505cc3dc..4b698f77 100644
--- a/src/py/libcamera/py_main.cpp
+++ b/src/py/libcamera/py_main.cpp
@@ -5,6 +5,8 @@
* Python bindings
*/
+#include "py_main.h"
+
#include <mutex>
#include <stdexcept>
#include <sys/eventfd.h>
@@ -23,6 +25,12 @@ namespace py = pybind11;
using namespace libcamera;
+namespace libcamera {
+
+LOG_DEFINE_CATEGORY(Python)
+
+}
+
template<typename T>
static py::object valueOrTuple(const ControlValue &cv)
{
@@ -120,10 +128,10 @@ static void handleRequestCompleted(Request *req)
size_t s = write(gEventfd, &v, 8);
/*
* We should never fail, and have no simple means to manage the error,
- * so let's use LOG(Fatal).
+ * so let's log a fatal error.
*/
if (s != 8)
- LOG(Fatal) << "Unable to write to eventfd";
+ LOG(Python, Fatal) << "Unable to write to eventfd";
}
void init_py_enums(py::module &m);
diff --git a/src/py/libcamera/py_main.h b/src/py/libcamera/py_main.h
new file mode 100644
index 00000000..5bb5f2d1
--- /dev/null
+++ b/src/py/libcamera/py_main.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
+/*
+ * Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
+ */
+
+#pragma once
+
+#include <libcamera/base/log.h>
+
+namespace libcamera {
+
+LOG_DECLARE_CATEGORY(Python)
+
+}