From c59272f417e03e1a64d12296d66ba0004f0aa78c Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Wed, 2 Jan 2019 03:54:44 +0200 Subject: libcamera: media_device: Zero media graph arrays when querying topology This silences valgrind that otherwise warns about usage of uninitialized values. While not strictly required as the kernel should fill the whole arrays in MEDIA_IOC_G_TOPOLOGY, the extra cost, in a non-critical path, is negligible compared to the ability to run without valgrind warnings. Signed-off-by: Laurent Pinchart --- src/libcamera/media_device.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp index 4ff9ffe1..cc307dac 100644 --- a/src/libcamera/media_device.cpp +++ b/src/libcamera/media_device.cpp @@ -240,10 +240,10 @@ int MediaDevice::populate() delete[] pads; delete[] interfaces; - ents = new media_v2_entity[topology.num_entities]; - links = new media_v2_link[topology.num_links]; - pads = new media_v2_pad[topology.num_pads]; - interfaces = new media_v2_interface[topology.num_interfaces]; + ents = new media_v2_entity[topology.num_entities](); + links = new media_v2_link[topology.num_links](); + pads = new media_v2_pad[topology.num_pads](); + interfaces = new media_v2_interface[topology.num_interfaces](); version = topology.topology_version; } -- cgit v1.2.1