From 74e86ad15ebad1396854d475159e75894c02286d Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Thu, 29 Feb 2024 02:32:34 +0200 Subject: pipeline: raspberrypi: common: Configure sensor embedded data Now that the CameraSensor class implements support for embedded data, use the corresponding API to enable or disable the embedded data stream. This changes requires sensor kernel drivers that implement the upstream embedded data API based on V4L2 streams. As the API is under development and not merged in the upstream kernel yet, this breaks compatibility with the downstream Raspberry Pi kernel. Signed-off-by: Laurent Pinchart --- src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'src') diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp index d662c8f1..9a2b8b90 100644 --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp @@ -527,6 +527,18 @@ int PipelineHandlerBase::configure(Camera *camera, CameraConfiguration *config) if (ret) return ret; + /* + * Configure embedded data on the sensor. Only check for errors when + * enabling embedded data, as some sensors don't support disabling it, + * and Unicam will simply drop the embedded data packets if we don't + * capture them. + */ + ret = data->sensor_->setEmbeddedDataEnabled(data->sensorMetadata_); + if (ret && data->sensorMetadata_) { + LOG(RPI, Error) << "Unable to enable embedded data: " << ret; + return ret; + } + /* * Platform specific internal stream configuration. This also assigns * external streams which get configured below. -- cgit v1.2.1