From 9d9481188fc3a4291b33a2d53e9e331cc2d7a023 Mon Sep 17 00:00:00 2001
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Mon, 3 Oct 2022 22:55:11 +0300
Subject: ipa: camera_sensor_helper: Return unique_ptr from createInstance

Avoid naked pointer with memory allocation by returning a unique_ptr
from CameraSensorHelperFactory::createInstance(), in order to increase
memory allocation safety.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/ipa/libipa/camera_sensor_helper.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/ipa/libipa/camera_sensor_helper.h')

diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h
index 410156ef..21ee43cc 100644
--- a/src/ipa/libipa/camera_sensor_helper.h
+++ b/src/ipa/libipa/camera_sensor_helper.h
@@ -73,7 +73,7 @@ private:
 
 	static void registerType(CameraSensorHelperFactory *factory);
 
-	virtual CameraSensorHelper *createInstance() const = 0;
+	virtual std::unique_ptr<CameraSensorHelper> createInstance() const = 0;
 
 	std::string name_;
 };
@@ -85,9 +85,9 @@ public: 							\
 	helper##Factory() : CameraSensorHelperFactory(name) {}	\
 								\
 private:							\
-	CameraSensorHelper *createInstance() const		\
+	std::unique_ptr<CameraSensorHelper> createInstance() const \
 	{							\
-		return new helper();				\
+		return std::make_unique<helper>();		\
 	}							\
 };								\
 static helper##Factory global_##helper##Factory;
-- 
cgit v1.2.1