From 74794de987c069250deba03c1a55ccd6f659e9e8 Mon Sep 17 00:00:00 2001 From: Cheng-Hao Yang Date: Fri, 22 Jul 2022 07:06:00 +0000 Subject: android: exif: Fix thumbnail buffer lifetime Previously the thumbnail buffer is destructed before even being used in Exif. This patch moves the buffer into class Exif, so that the developer won't need to worry about its lifetime. Signed-off-by: Harvey Yang Reviewed-by: Laurent Pinchart Reviewed-by: Umang Jain Signed-off-by: Umang Jain --- src/android/jpeg/exif.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/android/jpeg/exif.h') diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h index 2ff8fb78..e68716f3 100644 --- a/src/android/jpeg/exif.h +++ b/src/android/jpeg/exif.h @@ -10,6 +10,7 @@ #include #include #include +#include #include @@ -60,7 +61,7 @@ public: void setOrientation(int orientation); void setSize(const libcamera::Size &size); - void setThumbnail(libcamera::Span thumbnail, + void setThumbnail(std::vector &&thumbnail, Compression compression); void setTimestamp(time_t timestamp, std::chrono::milliseconds msec); @@ -106,4 +107,6 @@ private: unsigned char *exifData_; unsigned int size_; + + std::vector thumbnailData_; }; -- cgit v1.2.1