From dbe96a2a6b130f7a3ffa1ad037b96cbbd7514956 Mon Sep 17 00:00:00 2001 From: Matthias Fend Date: Mon, 20 Feb 2023 08:43:52 +0100 Subject: libcamera: Keep using syslog for isolated IPA modules Currently it is not possible to display debug output from an isolated IPA module. The standard descriptors are all closed and any specified log file is explicitly deactivated for the IPA module. Since libcamera and the isolated IPA module are separate processes, they cannot write to the same file. However, if syslog is used, then this would be possible. If syslog is specified as a log file, then this is left as it is for the isolated IPA module. Signed-off-by: Matthias Fend Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi Tested-by: Jacopo Mondi Signed-off-by: Jacopo Mondi --- src/libcamera/process.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp index 0e6b4e1d..86a382fb 100644 --- a/src/libcamera/process.cpp +++ b/src/libcamera/process.cpp @@ -263,7 +263,9 @@ int Process::start(const std::string &path, closeAllFdsExcept(fds); - unsetenv("LIBCAMERA_LOG_FILE"); + const char *file = utils::secure_getenv("LIBCAMERA_LOG_FILE"); + if (file && strcmp(file, "syslog")) + unsetenv("LIBCAMERA_LOG_FILE"); const char **argv = new const char *[args.size() + 2]; unsigned int len = args.size(); -- cgit v1.2.1