From 0862959184f2f59fb7d9a6787b3b53282ecca905 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20S=C3=B6derlund?= Date: Tue, 22 Sep 2020 15:36:12 +0200 Subject: libcamera: pipeline: rkisp1: Remove redundant check of buffer in Request MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There is no need to check if Request contains a buffer belonging the RkISP1 Camera as this is already done in Camera::queueRequest(), remove the redundant check. Reported-by: Laurent Pinchart Signed-off-by: Niklas Söderlund Reviewed-by: Jacopo Mondi --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 009d190d..77a48106 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -243,11 +243,6 @@ RkISP1FrameInfo *RkISP1Frames::create(unsigned int frame, Request *request, Stre FrameBuffer *statBuffer = pipe_->availableStatBuffers_.front(); FrameBuffer *videoBuffer = request->findBuffer(stream); - if (!videoBuffer) { - LOG(RkISP1, Error) - << "Attempt to queue request with invalid stream"; - return nullptr; - } pipe_->availableParamBuffers_.pop(); pipe_->availableStatBuffers_.pop(); -- cgit v1.2.1