summaryrefslogtreecommitdiff
path: root/test/v4l2_subdevice
diff options
context:
space:
mode:
authorNiklas Söderlund <niklas.soderlund@ragnatech.se>2019-04-14 00:28:53 +0200
committerNiklas Söderlund <niklas.soderlund@ragnatech.se>2019-05-17 01:33:12 +0200
commit12053cf8e6a98104b6c765e1ac8a34b8f7a02eed (patch)
treee9e45417a200c28e34ac23f53a8daa01591b495b /test/v4l2_subdevice
parentb9a47058eb46281dd0c365b9e18a323994791498 (diff)
libcamera: Always check return value of MediaDevice::acquire()
In preparation for adding more responsibility to MediaDevice::acquire() remove unneeded calls to acquire() and release(), and make sure all needed calls to acquire() are checked and acted on. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'test/v4l2_subdevice')
-rw-r--r--test/v4l2_subdevice/v4l2_subdevice_test.cpp7
1 files changed, 0 insertions, 7 deletions
diff --git a/test/v4l2_subdevice/v4l2_subdevice_test.cpp b/test/v4l2_subdevice/v4l2_subdevice_test.cpp
index 72d5f725..5810ef3c 100644
--- a/test/v4l2_subdevice/v4l2_subdevice_test.cpp
+++ b/test/v4l2_subdevice/v4l2_subdevice_test.cpp
@@ -45,20 +45,16 @@ int V4L2SubdeviceTest::init()
return TestSkip;
}
- media_->acquire();
-
int ret = media_->open();
if (ret) {
cerr << "Unable to open media device: " << media_->deviceNode()
<< ": " << strerror(ret) << endl;
- media_->release();
return TestSkip;
}
MediaEntity *videoEntity = media_->getEntityByName("Scaler");
if (!videoEntity) {
cerr << "Unable to find media entity 'Scaler'" << endl;
- media_->release();
return TestFail;
}
@@ -67,7 +63,6 @@ int V4L2SubdeviceTest::init()
if (ret) {
cerr << "Unable to open video subdevice "
<< scaler_->entity()->deviceNode() << endl;
- media_->release();
return TestSkip;
}
@@ -76,7 +71,5 @@ int V4L2SubdeviceTest::init()
void V4L2SubdeviceTest::cleanup()
{
- media_->release();
-
delete scaler_;
}