summaryrefslogtreecommitdiff
path: root/test/controls
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2019-09-28 02:22:57 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2019-10-05 20:02:51 +0300
commit5a952df386e2587e72dc378a1c97281e70ad57f5 (patch)
treedf3328fe93fee106dacf2358d00704e3eff0ead7 /test/controls
parent8ea6912c9607dab0a30c9bbf518dfc80df68a10c (diff)
libcamera: controls: Remove the unused ControlList::update() method
The ControlList::update() method is unused. While it is meant to fulfil a need of applications, having no user means that it is most probably not correctly designed. Remove the method, we will add it back later if needed. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Diffstat (limited to 'test/controls')
-rw-r--r--test/controls/control_list.cpp43
1 files changed, 0 insertions, 43 deletions
diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp
index 05369681..8469ecf0 100644
--- a/test/controls/control_list.cpp
+++ b/test/controls/control_list.cpp
@@ -141,49 +141,6 @@ protected:
return TestFail;
}
- /*
- * Test list merging. Create a new list, add two controls with
- * one overlapping the existing list, merge the lists and clear
- * the old list. Verify that the new list is empty and that the
- * new list contains the expected items and values.
- */
- ControlList newList(camera_.get());
-
- newList.set(controls::Brightness, 128);
- newList.set(controls::Saturation, 255);
- newList.update(list);
-
- list.clear();
-
- if (list.size() != 0) {
- cout << "Old List should contain zero items" << endl;
- return TestFail;
- }
-
- if (!list.empty()) {
- cout << "Old List should be empty" << endl;
- return TestFail;
- }
-
- if (newList.size() != 3) {
- cout << "New list has incorrect size" << endl;
- return TestFail;
- }
-
- if (!newList.contains(controls::Brightness) ||
- !newList.contains(controls::Contrast) ||
- !newList.contains(controls::Saturation)) {
- cout << "New list contains incorrect items" << endl;
- return TestFail;
- }
-
- if (newList.get(controls::Brightness) != 10 ||
- newList.get(controls::Contrast) != 20 ||
- newList.get(controls::Saturation) != 255) {
- cout << "New list contains incorrect values" << endl;
- return TestFail;
- }
-
return TestPass;
}