diff options
author | Jacopo Mondi <jacopo@jmondi.org> | 2020-09-24 16:03:31 +0200 |
---|---|---|
committer | Jacopo Mondi <jacopo@jmondi.org> | 2020-09-29 17:54:12 +0200 |
commit | 73bb12168fe74f5e557e8ee089209cc481d2c5ac (patch) | |
tree | afbf45298101b6ddc08ac797b52ac026a3fbd85a /src/cam/capture.h | |
parent | 60ade5d0e08cafb4643b9cd3aada6f586560db51 (diff) |
libcamera: ipu3: Adjust comment on ImgU configuration
Be more precise in commenting why the ImgU shall not be configured
if only the RAW stream is requested.
As an example, if the ImgU gets unecessary configured:
cam -srole=viewfinder -c2 -C -> WORKS
cam -srole=stillraw -c2 -C -> WORKS
cam -srole=viewfinder -c2 -C -> Failed to queue buffer 0: Invalid argument
Since commit ("libcamera: ipu3: Fix RAW+YUV capture") the ImgU
configuration procedure also correctly implements the assumption that at
least one of the YUV output is being operated. If that's not the case,
as in the RAW-only capture use case, the code tries to access a
non-existing configuration. One more reason to exit early if no YUV
stream is requested.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Diffstat (limited to 'src/cam/capture.h')
0 files changed, 0 insertions, 0 deletions