summaryrefslogtreecommitdiff
path: root/src/android/camera_hal_manager.h
diff options
context:
space:
mode:
authorJacopo Mondi <jacopo@jmondi.org>2021-10-18 16:49:07 +0200
committerJacopo Mondi <jacopo@jmondi.org>2021-10-19 09:54:36 +0200
commit375aeafb58efea248f64832b2e529284385bc777 (patch)
tree31d2ba0e834bb8d3cb5c1fb8980447ab98922ef5 /src/android/camera_hal_manager.h
parentc7ae5a50c10de1e790855d66842192c766da4dd3 (diff)
Revert "android: camera_device: Configure one stream for identical stream requests"
Commit d165f7da34b8 ("android: camera_device: Configure one stream for identical stream requests") introduced the ability to generate through post-processing YUV streams of identical size and format. However the change didn't fully take into account the situation where only mapped streams are contained in the request submitted by the camera service to the HAL. In this case the Request will be queued with no buffers and refused by the Camera. Even if this seems a corner case it causes a few CTS to fail, and more problematically it triggers out-of-order completion of requests, causing the camera service to abort. ERROR Camera camera.cpp:1031 Request contains no buffers ERROR HAL camera_device.cpp:1109 '\_SB_.PCI0.I2C2.CAM0': Out-of-order completion for request 0x00007a1f1800ccd0 ERROR cros_camera_service[15706:15711]: [camera_device_adapter.cc(744)] (15711) Notify(): Fatal device error; aborting the camera service Revert the commit until a proper solution is implemented. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Diffstat (limited to 'src/android/camera_hal_manager.h')
0 files changed, 0 insertions, 0 deletions