From 49856afa01c36d7e41f3a1ed31d7437e7e01dcc8 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Mon, 27 Apr 2020 01:22:01 +0300 Subject: utils: hooks: pre-push: Catch commits without reviews Improve the pre-push git hook script to reject commits without at least one Reviewed-by line. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- utils/hooks/pre-push | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'utils') diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push index 0eb8f5ce..5dc8adda 100755 --- a/utils/hooks/pre-push +++ b/utils/hooks/pre-push @@ -56,6 +56,13 @@ do echo >&2 "Missing committer Signed-off-by in commit $commit" errors=$((errors+1)) fi + + # 3. A Reviewed-by is required. + if ! echo "$msg" | grep -q '^Reviewed-by: ' + then + echo >&2 "No Reviewed-by in commit $commit" + errors=$((errors+1)) + fi done if [ $errors != 0 ] -- cgit v1.2.1