From 1526650fc781514200fed74bff0856b6fdbae850 Mon Sep 17 00:00:00 2001 From: Hirokazu Honda Date: Tue, 5 Oct 2021 16:31:14 +0900 Subject: test: Remove using namespace in header files "using namespace" in a header file propagates the namespace to the files including the header file. So it should be avoided. This removes "using namespace" in header files in test. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- test/v4l2_videodevice/buffer_sharing.cpp | 2 ++ test/v4l2_videodevice/capture_async.cpp | 2 ++ test/v4l2_videodevice/v4l2_videodevice_test.h | 14 ++++++-------- 3 files changed, 10 insertions(+), 8 deletions(-) (limited to 'test/v4l2_videodevice') diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp index 6af96a98..75ee93ce 100644 --- a/test/v4l2_videodevice/buffer_sharing.cpp +++ b/test/v4l2_videodevice/buffer_sharing.cpp @@ -20,6 +20,8 @@ #include "v4l2_videodevice_test.h" +using namespace libcamera; + class BufferSharingTest : public V4L2VideoDeviceTest { public: diff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp index 805cb610..3aa4ca0b 100644 --- a/test/v4l2_videodevice/capture_async.cpp +++ b/test/v4l2_videodevice/capture_async.cpp @@ -15,6 +15,8 @@ #include "v4l2_videodevice_test.h" +using namespace libcamera; + class CaptureAsyncTest : public V4L2VideoDeviceTest { public: diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.h b/test/v4l2_videodevice/v4l2_videodevice_test.h index d46540d4..e7762294 100644 --- a/test/v4l2_videodevice/v4l2_videodevice_test.h +++ b/test/v4l2_videodevice/v4l2_videodevice_test.h @@ -19,8 +19,6 @@ #include "test.h" -using namespace libcamera; - class V4L2VideoDeviceTest : public Test { public: @@ -36,12 +34,12 @@ protected: std::string driver_; std::string entity_; - std::unique_ptr enumerator_; - std::shared_ptr media_; - CameraSensor *sensor_; - V4L2Subdevice *debayer_; - V4L2VideoDevice *capture_; - std::vector> buffers_; + std::unique_ptr enumerator_; + std::shared_ptr media_; + libcamera::CameraSensor *sensor_; + libcamera::V4L2Subdevice *debayer_; + libcamera::V4L2VideoDevice *capture_; + std::vector> buffers_; }; #endif /* __LIBCAMERA_V4L2_DEVICE_TEST_H_ */ -- cgit v1.2.1