From 552ac5cfeccba4a37079533b4562358ac4a7b4f9 Mon Sep 17 00:00:00 2001 From: Kieran Bingham Date: Thu, 11 Mar 2021 13:57:27 +0000 Subject: libcamera: pipeline: ipu3: frames: Group FrameBuffer operations Ensure that checks on resource availability are handled first, and then operate on the queues only after the resources are confirmed as available. Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham --- src/libcamera/pipeline/ipu3/frames.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp index 151ebfe7..c7718fe7 100644 --- a/src/libcamera/pipeline/ipu3/frames.cpp +++ b/src/libcamera/pipeline/ipu3/frames.cpp @@ -49,12 +49,13 @@ IPU3Frames::Info *IPU3Frames::create(Request *request) LOG(IPU3, Error) << "Parameters buffer underrun"; return nullptr; } - FrameBuffer *paramBuffer = availableParamBuffers_.front(); if (availableStatBuffers_.empty()) { LOG(IPU3, Error) << "Statistics buffer underrun"; return nullptr; } + + FrameBuffer *paramBuffer = availableParamBuffers_.front(); FrameBuffer *statBuffer = availableStatBuffers_.front(); availableParamBuffers_.pop(); -- cgit v1.2.1