From 1c877bd8684d8e7743310d0b124ce0f9bf3aee79 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Mon, 30 Aug 2021 20:03:28 +0300 Subject: android: generic_camera_buffer: Fix bufferLength_ initialization The bufferLength_ member variabled is checked to have a positive value before being used, to catch usage before the variable is set. The variable is initialized to zero at construction time, which renders the checks useless. Fix this by initializing the variable to -1 at construction time. Fixes: c5e2ed7806be ("android: camera_buffer: Map buffer in the first plane() call") Signed-off-by: Laurent Pinchart Reviewed-by: Hirokazu Honda Reviewed-by: Jacopo Mondi --- src/android/mm/generic_camera_buffer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp index a41ae2c9..22efc4d4 100644 --- a/src/android/mm/generic_camera_buffer.cpp +++ b/src/android/mm/generic_camera_buffer.cpp @@ -60,7 +60,7 @@ CameraBuffer::Private::Private([[maybe_unused]] CameraBuffer *cameraBuffer, buffer_handle_t camera3Buffer, libcamera::PixelFormat pixelFormat, const libcamera::Size &size, int flags) - : fd_(-1), flags_(flags), bufferLength_(0), mapped_(false) + : fd_(-1), flags_(flags), bufferLength_(-1), mapped_(false) { error_ = 0; -- cgit v1.2.1