From 5b568b7e41e394b5317057312d07ff71b4d571f7 Mon Sep 17 00:00:00 2001 From: Helen Koike Date: Wed, 3 Feb 2021 11:29:55 -0300 Subject: libcamera: v4l2_videodevice: remove confusing memory MMAP assignment before QUERYBUF QUERYBUF doesn't require the memory field to be pre-filled. Also, V4L2VideoDevice::createBuffer uses dmabuf file descriptors, thus using V4L2_MEMORY_MMAP makes things confusing, so remove it. Signed-off-by: Helen Koike Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- src/libcamera/v4l2_videodevice.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'src/libcamera/v4l2_videodevice.cpp') diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp index a9509bff..c77e1aff 100644 --- a/src/libcamera/v4l2_videodevice.cpp +++ b/src/libcamera/v4l2_videodevice.cpp @@ -1255,7 +1255,6 @@ std::unique_ptr V4L2VideoDevice::createBuffer(unsigned int index) buf.index = index; buf.type = bufferType_; - buf.memory = V4L2_MEMORY_MMAP; buf.length = std::size(v4l2Planes); buf.m.planes = v4l2Planes; -- cgit v1.2.1