From dbafe16da7a9999ec77da21a42537702fb87f124 Mon Sep 17 00:00:00 2001
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Sun, 27 Oct 2019 00:36:13 +0300
Subject: meson: Remove -Wno-unused-parameter
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We build libcamera with -Wno-unused-parameter and this doesn't cause
much issue internally. However, it prevents catching unused parameters
in inline functions defined in public headers. This can lead to
compilation warnings for applications compiled without
-Wno-unused-parameter.

To catch those issues, remove -Wno-unused-parameter and fix all the
related warnings with [[maybe_unused]].

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/pub_key.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'src/libcamera/pub_key.cpp')

diff --git a/src/libcamera/pub_key.cpp b/src/libcamera/pub_key.cpp
index 2f60adbb..9bb08fda 100644
--- a/src/libcamera/pub_key.cpp
+++ b/src/libcamera/pub_key.cpp
@@ -30,7 +30,7 @@ namespace libcamera {
  * \brief Construct a PubKey from key data
  * \param[in] key Key data encoded in DER format
  */
-PubKey::PubKey(Span<const uint8_t> key)
+PubKey::PubKey([[maybe_unused]] Span<const uint8_t> key)
 	: valid_(false)
 {
 #if HAVE_GNUTLS
@@ -73,7 +73,8 @@ PubKey::~PubKey()
  *
  * \return True if the signature is valid, false otherwise
  */
-bool PubKey::verify(Span<const uint8_t> data, Span<const uint8_t> sig) const
+bool PubKey::verify([[maybe_unused]] Span<const uint8_t> data,
+		    [[maybe_unused]] Span<const uint8_t> sig) const
 {
 #if HAVE_GNUTLS
 	const gnutls_datum_t gnuTlsData{
-- 
cgit v1.2.1