From bfbc25785fcafb0ed2e14a19d2508238594065d3 Mon Sep 17 00:00:00 2001 From: Paul Elder Date: Fri, 12 Jul 2019 17:42:40 +0900 Subject: libcamera: process: fix error checking The return value of a read() call is mistakenly checked for nonzero rather than less than zero. Fix this. Fixes: df23ab95f3d7 ("libcamera: process: fix compilation on Chromium OS") Signed-off-by: Paul Elder --- src/libcamera/process.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/libcamera/process.cpp') diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp index aee33735..6c41da21 100644 --- a/src/libcamera/process.cpp +++ b/src/libcamera/process.cpp @@ -87,7 +87,8 @@ void sigact(int signal, siginfo_t *info, void *ucontext) void ProcessManager::sighandler(EventNotifier *notifier) { char data; - if (read(pipe_[0], &data, sizeof(data))) { + ssize_t ret = read(pipe_[0], &data, sizeof(data)); + if (ret < 0) { LOG(Process, Error) << "Failed to read byte from signal handler pipe"; return; -- cgit v1.2.1