From 4f509caa8ed0166ef2e99846f12b7997a37c3a7e Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Wed, 15 Jul 2020 01:41:07 +0300 Subject: libcamera: geometry: Give constructors to Rectangle MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Rectangle, unlike Size, has no constructor, requiring the users to explicitly initialize the instances. This is error-prone, add constructors. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- src/libcamera/pipeline/vimc/vimc.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'src/libcamera/pipeline/vimc') diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index a6f457c7..4f461b92 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -256,12 +256,7 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config) return ret; if (data->media_->version() >= KERNEL_VERSION(5, 6, 0)) { - Rectangle crop = { - .x = 0, - .y = 0, - .width = subformat.size.width, - .height = subformat.size.height, - }; + Rectangle crop{ 0, 0, subformat.size }; ret = data->scaler_->setSelection(0, V4L2_SEL_TGT_CROP, &crop); if (ret) return ret; -- cgit v1.2.1