From 8e137b08194ea73c63832750af5ad2930688aa8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20S=C3=B6derlund?= Date: Mon, 29 Jun 2020 18:29:56 +0200 Subject: libcamera: raspberrypi: Document vc_sm_cma pointer sharing with IPA MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sharing a pointer with the IPA is fragile as it will not work with all IPC mechanisms. Document that it's a temporary workaround that should be reworked. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/libcamera/pipeline/raspberrypi') diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 9d887b70..f4966f86 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1014,6 +1014,11 @@ int PipelineHandlerRPi::configureIPA(Camera *camera) /* * The vcsm allocation will always be in the memory region * < 32-bits to allow Videocore to access the memory. + * + * \todo Sending a pointer to the IPA is a workaround for + * vc_sm_cma not yet supporting dmabuf. This will not work with + * IPA module isolation and should be reworked when vc_sma_cma + * will permit. */ IPAOperationData op; op.operation = RPI_IPA_EVENT_LS_TABLE_ALLOCATION; -- cgit v1.2.1