From eab143ee69064092b6bb47297022efa80f47c120 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Sun, 29 Mar 2020 07:12:01 +0300 Subject: libcamera: ipa_manager: Verify IPA module signature MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Decide whether to isolate the IPA module using the module signature instead of its license. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- src/libcamera/ipa_manager.cpp | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) (limited to 'src/libcamera/ipa_manager.cpp') diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp index 6d23f470..7de1404e 100644 --- a/src/libcamera/ipa_manager.cpp +++ b/src/libcamera/ipa_manager.cpp @@ -12,6 +12,7 @@ #include #include +#include "file.h" #include "ipa_module.h" #include "ipa_proxy.h" #include "log.h" @@ -271,12 +272,12 @@ std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe, return nullptr; /* - * Load and run the IPA module in a thread if it is open-source, or - * isolate it in a separate process otherwise. + * Load and run the IPA module in a thread if it has a valid signature, + * or isolate it in a separate process otherwise. * * \todo Implement a better proxy selection */ - const char *proxyName = m->isOpenSource() + const char *proxyName = isSignatureValid(m) ? "IPAProxyThread" : "IPAProxyLinux"; IPAProxyFactory *pf = nullptr; @@ -301,4 +302,23 @@ std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe, return proxy; } +bool IPAManager::isSignatureValid(IPAModule *ipa) const +{ + File file{ ipa->path() }; + if (!file.open(File::ReadOnly)) + return false; + + Span data = file.map(); + if (data.empty()) + return false; + + bool valid = pubKey_.verify(data, ipa->signature()); + + LOG(IPAManager, Debug) + << "IPA module " << ipa->path() << " signature is " + << (valid ? "valid" : "not valid"); + + return valid; +} + } /* namespace libcamera */ -- cgit v1.2.1