From b3cdccbff9fb8e4da6eab06f2fe3e1f02aa29939 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Mon, 9 Sep 2019 13:26:37 +0300 Subject: libcamera: device_enumerator: Move lookupDeviceNode() to child classes The lookupDeviceNode() method is declared as pure virtual in the base DeviceEnumerator class, but is only called by derived classes. Move it to the DeviceEnumeratorSysfs and DeviceEnumeratorUdev. This allows changing the udev version to take a dev_t instead of separate major/minor, as that's what both the caller and the callee end up using. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Paul Elder --- src/libcamera/device_enumerator.cpp | 13 ------------- 1 file changed, 13 deletions(-) (limited to 'src/libcamera/device_enumerator.cpp') diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp index e76438af..0b596bce 100644 --- a/src/libcamera/device_enumerator.cpp +++ b/src/libcamera/device_enumerator.cpp @@ -306,17 +306,4 @@ std::shared_ptr DeviceEnumerator::search(const DeviceMatch &dm) return nullptr; } -/** - * \fn DeviceEnumerator::lookupDeviceNode(int major, int minor) - * \brief Lookup device node path from device number - * \param[in] major The device major number - * \param[in] minor The device minor number - * - * Translate a device number given as \a major and \a minor to a device node - * path. - * - * \return the device node path on success, or an empty string if the lookup - * fails - */ - } /* namespace libcamera */ -- cgit v1.2.1