From 1fca6228fece89c9270ff1abb293fdf48f1b577b Mon Sep 17 00:00:00 2001 From: Jacopo Mondi Date: Sun, 18 Apr 2021 16:42:17 +0200 Subject: libcamera: Drop argument from LIBCAMERA_DECLARE_PRIVATE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The LIBCAMERA_DECLARE_PRIVATE() macro, used by the library classes that inherit from libcamera::Extensible in order to implement the PIMPL pattern, expands to: public: \ class Private; \ friend class Private; The 'klass' argument is not used and it might confuse developers as it might hint that the class that defines the pattern's implementation can be freely named, while it is actually hardcoded to 'Private'. Drop the argument from the macro definition. Reviewed-by: Laurent Pinchart Reviewed-by: Niklas Söderlund Reviewed-by: Hanlin Chen Signed-off-by: Jacopo Mondi --- src/libcamera/class.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/libcamera/class.cpp') diff --git a/src/libcamera/class.cpp b/src/libcamera/class.cpp index 340b7de7..171f7c0a 100644 --- a/src/libcamera/class.cpp +++ b/src/libcamera/class.cpp @@ -77,12 +77,10 @@ namespace libcamera { /** * \def LIBCAMERA_DECLARE_PRIVATE * \brief Declare private data for a public class - * \param klass The public class name * * The LIBCAMERA_DECLARE_PRIVATE() macro plumbs the infrastructure necessary to * make a class manage its private data through a d-pointer. It shall be used at - * the very top of the class definition, with the public class name passed as - * the \a klass parameter. + * the very top of the class definition. */ /** -- cgit v1.2.1