From 021752924b1721db9aae656af6910b50fb78915f Mon Sep 17 00:00:00 2001 From: Jacopo Mondi Date: Sat, 2 Jan 2021 11:35:32 +0100 Subject: libcamera: camera_sensor: Make V4L2_CID_EXPOSURE mandatory Add the V4L2_CID_EXPOSURE control to the list of mandatory controls the sensor driver has to report and document this new requirement. While at it, re-sort the mandatory V4L2 controls in alphabetical order in the CameraSensor class and remove the above comment as the usage of the controls is better reported in the documentation. Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- src/libcamera/camera_sensor.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/libcamera/camera_sensor.cpp') diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp index 9abb9d33..ca33c009 100644 --- a/src/libcamera/camera_sensor.cpp +++ b/src/libcamera/camera_sensor.cpp @@ -239,12 +239,11 @@ int CameraSensor::validateSensorDriver() /* * Make sure the sensor driver supports the mandatory controls * required by the CameraSensor class. - * - V4L2_CID_PIXEL_RATE is used to calculate the sensor timings - * - V4L2_CID_HBLANK is used to calculate the line length */ const std::vector mandatoryControls{ - V4L2_CID_PIXEL_RATE, + V4L2_CID_EXPOSURE, V4L2_CID_HBLANK, + V4L2_CID_PIXEL_RATE, }; ControlList ctrls = subdev_->getControls(mandatoryControls); -- cgit v1.2.1