From 58f558fddaf3d7d149ab1c320c2cee7c6948ec01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20S=C3=B6derlund?= Date: Tue, 13 Apr 2021 23:46:45 +0200 Subject: lc-compliance: Drop return value from SimpleCapture::stop() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The return value is never checked and serves to real usage, drop it. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- src/lc-compliance/simple_capture.cpp | 4 +--- src/lc-compliance/simple_capture.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'src/lc-compliance') diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp index 8f714d3b..811a6220 100644 --- a/src/lc-compliance/simple_capture.cpp +++ b/src/lc-compliance/simple_capture.cpp @@ -50,7 +50,7 @@ Results::Result SimpleCapture::start() return { Results::Pass, "Started camera" }; } -Results::Result SimpleCapture::stop() +void SimpleCapture::stop() { Stream *stream = config_->at(0).stream(); @@ -59,8 +59,6 @@ Results::Result SimpleCapture::stop() camera_->requestCompleted.disconnect(this, &SimpleCapture::requestComplete); allocator_->free(stream); - - return { Results::Pass, "Stopped camera" }; } /* SimpleCaptureBalanced */ diff --git a/src/lc-compliance/simple_capture.h b/src/lc-compliance/simple_capture.h index 4693c134..d9de53fb 100644 --- a/src/lc-compliance/simple_capture.h +++ b/src/lc-compliance/simple_capture.h @@ -24,7 +24,7 @@ protected: virtual ~SimpleCapture(); Results::Result start(); - Results::Result stop(); + void stop(); virtual void requestComplete(libcamera::Request *request) = 0; -- cgit v1.2.1