From 210b81104730d32c47a689e3217f58f344c50f8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20S=C3=B6derlund?= Date: Fri, 5 Feb 2021 16:25:10 +0100 Subject: lc-compliance: Add test stopping single stream with requests queued MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add a test which stops a camera while requests are still queued. This intends to test cleanup paths where requests are dequeued from video devices in an uncompleted state. Signed-off-by: Niklas Söderlund Acked-by: Kieran Bingham Tested-by: Kieran Bingham Reviewed-by: Laurent Pinchart Tested-by: Jean-Michel Hautbois --- src/lc-compliance/single_stream.cpp | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) (limited to 'src/lc-compliance/single_stream.cpp') diff --git a/src/lc-compliance/single_stream.cpp b/src/lc-compliance/single_stream.cpp index e9ca1d58..8318b42f 100644 --- a/src/lc-compliance/single_stream.cpp +++ b/src/lc-compliance/single_stream.cpp @@ -33,6 +33,18 @@ Results::Result testRequestBalance(std::shared_ptr camera, std::to_string(startCycles) + " start cycles" }; } +Results::Result testRequestUnbalance(std::shared_ptr camera, + StreamRole role, unsigned int numRequests) +{ + SimpleCaptureUnbalanced capture(camera); + + Results::Result ret = capture.configure(role); + if (ret.first != Results::Pass) + return ret; + + return capture.capture(numRequests); +} + Results testSingleStream(std::shared_ptr camera) { static const std::vector> roles = { @@ -43,7 +55,7 @@ Results testSingleStream(std::shared_ptr camera) }; static const std::vector numRequests = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 }; - Results results(numRequests.size() * roles.size() * 2); + Results results(numRequests.size() * roles.size() * 3); for (const auto &role : roles) { std::cout << "= Test role " << role.first << std::endl; @@ -68,6 +80,17 @@ Results testSingleStream(std::shared_ptr camera) std::cout << "* Test multiple start/stop cycles" << std::endl; for (unsigned int num : numRequests) results.add(testRequestBalance(camera, role.second, 3, num)); + + /* + * Test unbalanced stop + * + * Makes sure the camera supports a stop with requests queued. + * Example failure is a camera that does not handle cancelation + * of buffers coming back from the video device while stopping. + */ + std::cout << "* Test unbalanced stop" << std::endl; + for (unsigned int num : numRequests) + results.add(testRequestUnbalance(camera, role.second, num)); } return results; -- cgit v1.2.1