From 2ea57d0b7702efb6e290f7ec2ef35b5646f91a6c Mon Sep 17 00:00:00 2001 From: David Plowman Date: Fri, 28 Jul 2023 14:36:58 +0100 Subject: ipa: rpi: agc: Fetch AWB status in process method, not prepare prepare() doesn't use the AWB status, so fetching it in process() is probably better. This change is preparatory to other changes, where we may find ourselves calling process() without having called prepare() previously. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck Reviewed-by: Jacopo Mondi Signed-off-by: Kieran Bingham --- src/ipa/rpi/controller/rpi/agc.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/ipa/rpi') diff --git a/src/ipa/rpi/controller/rpi/agc.cpp b/src/ipa/rpi/controller/rpi/agc.cpp index ae9ff219..e8526355 100644 --- a/src/ipa/rpi/controller/rpi/agc.cpp +++ b/src/ipa/rpi/controller/rpi/agc.cpp @@ -424,7 +424,6 @@ void Agc::prepare(Metadata *imageMetadata) totalExposureValue = delayedStatus.totalExposureValue; status_.digitalGain = 1.0; - fetchAwbStatus(imageMetadata); /* always fetch it so that Process knows it's been done */ if (status_.totalExposureValue) { /* Process has run, so we have meaningful values. */ @@ -461,6 +460,8 @@ void Agc::process(StatisticsPtr &stats, Metadata *imageMetadata) * configuration, that kind of thing. */ housekeepConfig(); + /* Fetch the AWB status immediately, so that we can assume it's there. */ + fetchAwbStatus(imageMetadata); /* Get the current exposure values for the frame that's just arrived. */ fetchCurrentExposure(imageMetadata); /* Compute the total gain we require relative to the current exposure. */ -- cgit v1.2.1