From 7986d3d3c17e1ca7c2aa488175a88a4743ed2203 Mon Sep 17 00:00:00 2001 From: Mikhail Rudenko Date: Mon, 23 Jan 2023 17:06:19 +0300 Subject: ipa: rkisp1: Raise maximum analogue gain Omnivision OV4689 sensor driver exposes maximum analogue gain of 16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can be used. Signed-off-by: Mikhail Rudenko Reviewed-by: Jacopo Mondi Signed-off-by: Jacopo Mondi --- src/ipa/rkisp1/algorithms/agc.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'src/ipa/rkisp1') diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index e3470e25..22f70aba 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -36,9 +36,14 @@ namespace ipa::rkisp1::algorithms { LOG_DEFINE_CATEGORY(RkISP1Agc) -/* Limits for analogue gain values */ +/* + * Limits for analogue gain values + * + * \todo Remove the hard-coded limits and let the sensor helper specify + * the minimum and maximum allowed gain values. + */ static constexpr double kMinAnalogueGain = 1.0; -static constexpr double kMaxAnalogueGain = 8.0; +static constexpr double kMaxAnalogueGain = 16.0; /* \todo Honour the FrameDurationLimits control instead of hardcoding a limit */ static constexpr utils::Duration kMaxShutterSpeed = 60ms; -- cgit v1.2.1