From 68683d3811a803aa087c38a2063cf64c8d084d49 Mon Sep 17 00:00:00 2001
From: Marvin Schmidt <marvin.schmidt1987@gmail.com>
Date: Mon, 29 Aug 2022 20:28:46 +0200
Subject: ipa: rkisp1: lsc: Use double instead of float to accumulate vector of
doubles
clang-tidy's bugprone-fold-init-type check warns about this:
> ../src/ipa/rkisp1/algorithms/lsc.cpp:61:14: warning: folding type 'double' into type 'float' might result in loss of precision [bugprone-fold-init-type]
> float sum = std::accumulate(sizes.begin(), sizes.end(), 0.0f);
> ^
Fixes: b3e96411d8a9 ("ipa: rkisp1: Add support of Lens Shading Correction control")
Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
src/ipa/rkisp1/algorithms/lsc.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
(limited to 'src/ipa/rkisp1/algorithms')
diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp
index da287ac7..b9efc063 100644
--- a/src/ipa/rkisp1/algorithms/lsc.cpp
+++ b/src/ipa/rkisp1/algorithms/lsc.cpp
@@ -58,7 +58,7 @@ static std::vector<double> parseSizes(const YamlObject &tuningData,
* prevent an exact match (further adjustments will be performed in
* LensShadingCorrection::prepare()).
*/
- float sum = std::accumulate(sizes.begin(), sizes.end(), 0.0f);
+ double sum = std::accumulate(sizes.begin(), sizes.end(), 0.0);
if (sum < 0.495 || sum > 0.505) {
LOG(RkISP1Lsc, Error)
<< "Invalid '" << prop << "' values: sum of the elements"
--
cgit v1.2.1