From 9fe81a51abd2ad875e4343df5f0c2007242b8bcf Mon Sep 17 00:00:00 2001 From: David Plowman <david.plowman@raspberrypi.com> Date: Wed, 17 Feb 2021 15:24:00 +0000 Subject: ipa: raspberrypi: Do not require SDN (spatial denoise) algorithm A camera tuning is not required to load an SDN algorithm. In keeping with other controls, do not fail when a particular control was expecting this algorithm, just warn that it is not present. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Naushir Patuck <naush@raspberrypi.com> Signed-off-by: David Plowman <david.plowman@raspberrypi.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- src/ipa/raspberrypi/raspberrypi.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/ipa/raspberrypi') diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 81a3195c..4608dfd4 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -875,7 +875,11 @@ void IPARPi::queueRequest(const ControlList &controls) case controls::NOISE_REDUCTION_MODE: { RPiController::DenoiseAlgorithm *sdn = dynamic_cast<RPiController::DenoiseAlgorithm *>( controller_.GetAlgorithm("SDN")); - ASSERT(sdn); + if (!sdn) { + LOG(IPARPI, Warning) + << "Could not set NOISE_REDUCTION_MODE - no SDN algorithm"; + break; + } int32_t idx = ctrl.second.get<int32_t>(); auto mode = DenoiseModeTable.find(idx); -- cgit v1.2.1