From 726e9274ea95fa46352556d340c5793a8da51fcd Mon Sep 17 00:00:00 2001 From: Naushir Patuck Date: Wed, 3 May 2023 13:20:27 +0100 Subject: pipeline: ipa: raspberrypi: Refactor and move the Raspberry Pi code Split the Raspberry Pi pipeline handler and IPA source code into common and VC4/BCM2835 specific file structures. For the pipeline handler, the common code files now live in src/libcamera/pipeline/rpi/common/ and the VC4-specific files in src/libcamera/pipeline/rpi/vc4/. For the IPA, the common code files now live in src/ipa/rpi/{cam_helper,controller}/ and the vc4 specific files in src/ipa/rpi/vc4/. With this change, the camera tuning files are now installed under share/libcamera/ipa/rpi/vc4/. To build the pipeline and IPA, the meson configuration options have now changed from "raspberrypi" to "rpi/vc4": meson setup build -Dipas=rpi/vc4 -Dpipelines=rpi/vc4 Signed-off-by: Naushir Patuck Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- src/ipa/raspberrypi/cam_helper_ov5647.cpp | 109 ------------------------------ 1 file changed, 109 deletions(-) delete mode 100644 src/ipa/raspberrypi/cam_helper_ov5647.cpp (limited to 'src/ipa/raspberrypi/cam_helper_ov5647.cpp') diff --git a/src/ipa/raspberrypi/cam_helper_ov5647.cpp b/src/ipa/raspberrypi/cam_helper_ov5647.cpp deleted file mode 100644 index 5a99083d..00000000 --- a/src/ipa/raspberrypi/cam_helper_ov5647.cpp +++ /dev/null @@ -1,109 +0,0 @@ -/* SPDX-License-Identifier: BSD-2-Clause */ -/* - * Copyright (C) 2019, Raspberry Pi Ltd - * - * cam_helper_ov5647.cpp - camera information for ov5647 sensor - */ - -#include - -#include "cam_helper.h" - -using namespace RPiController; - -class CamHelperOv5647 : public CamHelper -{ -public: - CamHelperOv5647(); - uint32_t gainCode(double gain) const override; - double gain(uint32_t gainCode) const override; - void getDelays(int &exposureDelay, int &gainDelay, - int &vblankDelay, int &hblankDelay) const override; - unsigned int hideFramesStartup() const override; - unsigned int hideFramesModeSwitch() const override; - unsigned int mistrustFramesStartup() const override; - unsigned int mistrustFramesModeSwitch() const override; - -private: - /* - * Smallest difference between the frame length and integration time, - * in units of lines. - */ - static constexpr int frameIntegrationDiff = 4; -}; - -/* - * OV5647 doesn't output metadata, so we have to use the "unicam parser" which - * works by counting frames. - */ - -CamHelperOv5647::CamHelperOv5647() - : CamHelper({}, frameIntegrationDiff) -{ -} - -uint32_t CamHelperOv5647::gainCode(double gain) const -{ - return static_cast(gain * 16.0); -} - -double CamHelperOv5647::gain(uint32_t gainCode) const -{ - return static_cast(gainCode) / 16.0; -} - -void CamHelperOv5647::getDelays(int &exposureDelay, int &gainDelay, - int &vblankDelay, int &hblankDelay) const -{ - /* - * We run this sensor in a mode where the gain delay is bumped up to - * 2. It seems to be the only way to make the delays "predictable". - */ - exposureDelay = 2; - gainDelay = 2; - vblankDelay = 2; - hblankDelay = 2; -} - -unsigned int CamHelperOv5647::hideFramesStartup() const -{ - /* - * On startup, we get a couple of under-exposed frames which - * we don't want shown. - */ - return 2; -} - -unsigned int CamHelperOv5647::hideFramesModeSwitch() const -{ - /* - * After a mode switch, we get a couple of under-exposed frames which - * we don't want shown. - */ - return 2; -} - -unsigned int CamHelperOv5647::mistrustFramesStartup() const -{ - /* - * First couple of frames are under-exposed and are no good for control - * algos. - */ - return 2; -} - -unsigned int CamHelperOv5647::mistrustFramesModeSwitch() const -{ - /* - * First couple of frames are under-exposed even after a simple - * mode switch, and are no good for control algos. - */ - return 2; -} - -static CamHelper *create() -{ - return new CamHelperOv5647(); -} - -static RegisterCamHelper reg("ov5647", &create); -- cgit v1.2.1