From c4d39f0c31d968d874b8519af7458cbb34e3abe0 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Mon, 3 Oct 2022 22:55:11 +0300 Subject: ipa: camera_sensor_helper: Make factory createInstance() function const The CameraSensorHelperFactory::createInstance() function has no need to modify the factory instance. Make it const. Signed-off-by: Laurent Pinchart Reviewed-by: Xavier Roumegue Reviewed-by: Jacopo Mondi --- src/ipa/libipa/camera_sensor_helper.cpp | 6 +++--- src/ipa/libipa/camera_sensor_helper.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src/ipa/libipa') diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index d4dba497..fde9bf5b 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -254,10 +254,10 @@ CameraSensorHelperFactory::CameraSensorHelperFactory(const std::string name) */ std::unique_ptr CameraSensorHelperFactory::create(const std::string &name) { - std::vector &factories = + const std::vector &factories = CameraSensorHelperFactory::factories(); - for (CameraSensorHelperFactory *factory : factories) { + for (const CameraSensorHelperFactory *factory : factories) { if (name != factory->name_) continue; @@ -299,7 +299,7 @@ std::vector &CameraSensorHelperFactory::factories() } /** - * \fn CameraSensorHelperFactory::createInstance() + * \fn CameraSensorHelperFactory::createInstance() const * \brief Create an instance of the CameraSensorHelper corresponding to the * factory * diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h index 7351fc7c..2042847f 100644 --- a/src/ipa/libipa/camera_sensor_helper.h +++ b/src/ipa/libipa/camera_sensor_helper.h @@ -70,7 +70,7 @@ public: static std::vector &factories(); protected: - virtual CameraSensorHelper *createInstance() = 0; + virtual CameraSensorHelper *createInstance() const = 0; private: LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory) @@ -85,7 +85,7 @@ public: \ helper##Factory() : CameraSensorHelperFactory(name) {} \ \ private: \ - CameraSensorHelper *createInstance() \ + CameraSensorHelper *createInstance() const \ { \ return new helper(); \ } \ -- cgit v1.2.1