From 8ca491cbf1a5cede5757ce15c7b5be30f7b26d68 Mon Sep 17 00:00:00 2001 From: Kieran Bingham Date: Wed, 23 Mar 2022 13:24:40 +0000 Subject: ipa: ipu3: af: Simplify accumulations of y_items Simplify the accumulation of the total and variance with a ternary operator. Signed-off-by: Kieran Bingham Reviewed-by: Jean-Michel Hautbois Tested-by: Jean-Michel Hautbois Tested-by: Kate Hsuan Reviewed-by: Laurent Pinchart --- src/ipa/ipu3/algorithms/af.cpp | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) (limited to 'src/ipa/ipu3') diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp index f243aceb..addf98af 100644 --- a/src/ipa/ipu3/algorithms/af.cpp +++ b/src/ipa/ipu3/algorithms/af.cpp @@ -360,20 +360,14 @@ double Af::afEstimateVariance(Span y_items, bool isY1) double mean; double var_sum = 0; - for (auto y : y_items) { - if (isY1) - total += y.y1_avg; - else - total += y.y2_avg; - } + for (auto y : y_items) + total += isY1 ? y.y1_avg : y.y2_avg; mean = total / y_items.size(); for (auto y : y_items) { - if (isY1) - var_sum += pow(y.y1_avg - mean, 2); - else - var_sum += pow(y.y2_avg - mean, 2); + double avg = isY1 ? y.y1_avg : y.y2_avg; + var_sum += pow(avg - mean, 2); } return var_sum / y_items.size(); -- cgit v1.2.1